svd: Let the Python code handle the info != 0 case to avoid XLA error

JanLuca · JanLuca · commit 7141617f3f3b · 2025-08-15T16:00:24.000+02:00
diff --git a/varipeps/utils/extensions/svd_ffi.cpp b/varipeps/utils/extensions/svd_ffi.cpp
@@ -145,7 +145,8 @@ static ffi::Error SvdOnlyUVtImpl(
   }
 
   if (*info_data != 0) {
-    return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
+    return ffi::Error::Success();
+    // return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
   }
 
   if (std::real(work_size) > lapack_int_max) [[unlikely]] {
@@ -181,9 +182,9 @@ static ffi::Error SvdOnlyUVtImpl(
        );
   }
 
-  if (*info_data != 0) {
-    return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
-  }
+  // if (*info_data != 0) {
+  //   return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
+  // }
 
   return ffi::Error::Success();
 }
@@ -340,7 +341,8 @@ static ffi::Error SvdOnlyUVtQRImpl(
   }
 
   if (*info_data != 0) {
-    return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
+    return ffi::Error::Success();
+    // return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
   }
 
   if (std::real(work_size) > lapack_int_max) [[unlikely]] {
@@ -373,9 +375,9 @@ static ffi::Error SvdOnlyUVtQRImpl(
        );
   }
 
-  if (*info_data != 0) {
-    return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
-  }
+  // if (*info_data != 0) {
+  //   return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");
+  // }
 
   return ffi::Error::Success();
 }

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,8 @@ static ffi::Error SvdOnlyUVtImpl(`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`if (*info_data != 0) {`
`148`		`- return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
	`148`	`+ return ffi::Error::Success();`
	`149`	`+ // return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
`149`	`150`	`}`
`150`	`151`
`151`	`152`	`if (std::real(work_size) > lapack_int_max) [[unlikely]] {`
`@@ -181,9 +182,9 @@ static ffi::Error SvdOnlyUVtImpl(`
`181`	`182`	`);`
`182`	`183`	`}`
`183`	`184`
`184`		`- if (*info_data != 0) {`
`185`		`- return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
`186`		`- }`
	`185`	`+ // if (*info_data != 0) {`
	`186`	`+ // return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
	`187`	`+ // }`
`187`	`188`
`188`	`189`	`return ffi::Error::Success();`
`189`	`190`	`}`
`@@ -340,7 +341,8 @@ static ffi::Error SvdOnlyUVtQRImpl(`
`340`	`341`	`}`
`341`	`342`
`342`	`343`	`if (*info_data != 0) {`
`343`		`- return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
	`344`	`+ return ffi::Error::Success();`
	`345`	`+ // return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
`344`	`346`	`}`
`345`	`347`
`346`	`348`	`if (std::real(work_size) > lapack_int_max) [[unlikely]] {`
`@@ -373,9 +375,9 @@ static ffi::Error SvdOnlyUVtQRImpl(`
`373`	`375`	`);`
`374`	`376`	`}`
`375`	`377`
`376`		`- if (*info_data != 0) {`
`377`		`- return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
`378`		`- }`
	`378`	`+ // if (*info_data != 0) {`
	`379`	`+ // return ffi::Error(ffi::ErrorCode::kInternal, "Non zero info returned by lapack.");`
	`380`	`+ // }`
`379`	`381`
`380`	`382`	`return ffi::Error::Success();`
`381`	`383`	`}`