properly pass promise in sslSupportedReceived although it'll always be nil anyways

Author: MahdiBM

Sources/PostgresNIO/New/Connection State Machine/ConnectionStateMachine.swift

@@ -229,14 +229,14 @@ struct ConnectionStateMachine {
         }
     }
 
-    mutating func sslSupportedReceived(unprocessedBytes: Int) -> ConnectionAction {
+    mutating func sslSupportedReceived(unprocessedBytes: Int, promise: EventLoopPromise<Void>?) -> ConnectionAction {
         switch self.state {
         case .sslRequestSent:
             if unprocessedBytes > 0 {
-                return self.closeConnectionAndCleanup(.receivedUnencryptedDataAfterSSLRequest)
+                return self.closeConnectionAndCleanup(.receivedUnencryptedDataAfterSSLRequest, closePromise: promise)
             }
             self.state = .sslNegotiated
-            return .establishSSLConnection(nil)
+            return .establishSSLConnection(promise)
 
         case .initialized,
              .sslNegotiated,
@@ -249,8 +249,8 @@ struct ConnectionStateMachine {
              .closeCommand,
              .closing,
              .closed:
-            return self.closeConnectionAndCleanup(.unexpectedBackendMessage(.sslSupported))
-            
+            return self.closeConnectionAndCleanup(.unexpectedBackendMessage(.sslSupported), closePromise: promise)
+
         case .modifying:
             preconditionFailure("Invalid state: \(self.state)")
         }

Sources/PostgresNIO/New/PostgresChannelHandler.swift

@@ -161,7 +161,7 @@ final class PostgresChannelHandler: ChannelDuplexHandler {
         case .rowDescription(let rowDescription):
             action = self.state.rowDescriptionReceived(rowDescription)
         case .sslSupported:
-            action = self.state.sslSupportedReceived(unprocessedBytes: self.decoder.unprocessedBytes)
+            action = self.state.sslSupportedReceived(unprocessedBytes: self.decoder.unprocessedBytes, promise: nil)
         case .sslUnsupported:
             action = self.state.sslUnsupportedReceived()
         }

Tests/PostgresNIOTests/New/Connection State Machine/ConnectionStateMachineTests.swift

@@ -19,7 +19,7 @@ class ConnectionStateMachineTests: XCTestCase {
         let authContext = AuthContext(username: "test", password: "abc123", database: "test")
         var state = ConnectionStateMachine(requireBackendKeyData: true)
         XCTAssertEqual(state.connected(tls: .require, promise: nil), .sendSSLRequest(nil))
-        XCTAssertEqual(state.sslSupportedReceived(unprocessedBytes: 0), .establishSSLConnection(nil))
+        XCTAssertEqual(state.sslSupportedReceived(unprocessedBytes: 0, promise: nil), .establishSSLConnection(nil))
         XCTAssertEqual(state.sslHandlerAdded(), .wait)
         XCTAssertEqual(state.sslEstablished(), .provideAuthenticationContext)
         XCTAssertEqual(state.provideAuthenticationContext(authContext, promise: nil), .sendStartupMessage(authContext, promise: nil))
@@ -31,15 +31,15 @@ class ConnectionStateMachineTests: XCTestCase {
         var state = ConnectionStateMachine(requireBackendKeyData: true)
         XCTAssertEqual(state.connected(tls: .require, promise: nil), .sendSSLRequest(nil))
         let failError = PSQLError.receivedUnencryptedDataAfterSSLRequest
-        XCTAssertEqual(state.sslSupportedReceived(unprocessedBytes: 1), .closeConnectionAndCleanup(.init(action: .close, tasks: [], error: failError, closePromise: nil)))
+        XCTAssertEqual(state.sslSupportedReceived(unprocessedBytes: 1, promise: nil), .closeConnectionAndCleanup(.init(action: .close, tasks: [], error: failError, closePromise: nil)))
     }
 
     func testSSLStartupFailHandler() {
         struct SSLHandlerAddError: Error, Equatable {}
 
         var state = ConnectionStateMachine(requireBackendKeyData: true)
         XCTAssertEqual(state.connected(tls: .require, promise: nil), .sendSSLRequest(nil))
-        XCTAssertEqual(state.sslSupportedReceived(unprocessedBytes: 0), .establishSSLConnection(nil))
+        XCTAssertEqual(state.sslSupportedReceived(unprocessedBytes: 0, promise: nil), .establishSSLConnection(nil))
         let failError = PSQLError.failedToAddSSLHandler(underlying: SSLHandlerAddError())
         XCTAssertEqual(state.errorHappened(failError), .closeConnectionAndCleanup(.init(action: .close, tasks: [], error: failError, closePromise: nil)))
     }