Update TypeScript to 5.8.3, modernize tsconfig (#1578)

Author: askoufis

benchmarks/package.json

@@ -8,6 +8,6 @@
     "@arktype/attest": "^0.43.3",
     "@vanilla-extract/css": "workspace:*",
     "tsx": "^4.17.0",
-    "typescript": "^5.5.4"
+    "typescript": "^5.8.3"
   }
 }

fixtures/thirdparty/src/styles.css.ts

@@ -5,7 +5,6 @@ export {
   depColor,
   depdepBlock,
   depdepColor,
-  // @ts-expect-error no types
 } from '@fixtures/thirdparty-dep';
 
 const color = createVar();

package.json

@@ -48,7 +48,7 @@
     "jest-environment-jsdom": "^29.7.0",
     "prettier": "^2.8.8",
     "tsx": "^4.17.0",
-    "typescript": "^5.5.4",
+    "typescript": "^5.8.3",
     "vitest": "^3.0.2"
   },
   "preconstruct": {

packages/babel-plugin-debug-ids/src/index.ts

@@ -1,4 +1,9 @@
-import { types as t, PluginObj, PluginPass, NodePath } from '@babel/core';
+import {
+  types as t,
+  type PluginObj,
+  type PluginPass,
+  type NodePath,
+} from '@babel/core';
 
 const packageIdentifiers = new Set([
   '@vanilla-extract/css',

packages/css/src/validateContract.ts

@@ -1,4 +1,4 @@
-import { Contract, walkObject } from '@vanilla-extract/private';
+import { type Contract, walkObject } from '@vanilla-extract/private';
 import { diff } from 'deep-object-diff';
 import pc from 'picocolors';
 

packages/css/src/vars.ts

@@ -3,17 +3,17 @@ import type { AtRule } from 'csstype';
 import {
   get,
   walkObject,
-  Contract,
-  MapLeafNodes,
-  CSSVarFunction,
+  type Contract,
+  type MapLeafNodes,
+  type CSSVarFunction,
 } from '@vanilla-extract/private';
 import cssesc from 'cssesc';
 
-import { Tokens, NullableTokens, ThemeVars } from './types';
+import type { Tokens, NullableTokens, ThemeVars } from './types';
 import { validateContract } from './validateContract';
 import { getFileScope } from './fileScope';
 import { generateIdentifier } from './identifier';
-import { PropertySyntax } from './types';
+import type { PropertySyntax } from './types';
 import { appendCss } from './adapter';
 
 type VarDeclaration =

packages/dynamic/src/assignInlineVars.ts

@@ -2,8 +2,8 @@ import {
   walkObject,
   get,
   getVarName,
-  Contract,
-  MapLeafNodes,
+  type Contract,
+  type MapLeafNodes,
 } from '@vanilla-extract/private';
 
 type Styles = { [cssVarName: string]: string };

packages/dynamic/src/setElementVars.ts

@@ -2,8 +2,8 @@ import {
   get,
   walkObject,
   getVarName,
-  Contract,
-  MapLeafNodes,
+  type Contract,
+  type MapLeafNodes,
 } from '@vanilla-extract/private';
 
 function setVar(element: HTMLElement, variable: string, value: string) {

packages/esbuild-plugin-next/src/index.ts

@@ -7,7 +7,7 @@ import {
 import {
   cssFileFilter,
   vanillaExtractTransformPlugin,
-  IdentifierOption,
+  type IdentifierOption,
 } from '@vanilla-extract/integration';
 import type { Plugin } from 'esbuild';
 

packages/esbuild-plugin/src/index.ts

@@ -7,8 +7,8 @@ import {
   getSourceFromVirtualCssFile,
   compile,
   vanillaExtractTransformPlugin,
-  IdentifierOption,
-  CompileOptions,
+  type IdentifierOption,
+  type CompileOptions,
 } from '@vanilla-extract/integration';
 import type { Plugin } from 'esbuild';
 
@@ -70,7 +70,7 @@ export function vanillaExtractPlugin({
       );
 
       build.onLoad({ filter: cssFileFilter }, async ({ path }) => {
-        const combinedEsbuildOptions = { ...esbuildOptions } ?? {};
+        const combinedEsbuildOptions = { ...esbuildOptions };
         const identOption =
           identifiers ?? (build.initialOptions.minify ? 'short' : 'debug');