18-1-3-release-candidate (#6695)

lexasq · daniloff200 · web-flow · commit f09e4b15464b · 2024-10-28T15:56:54.000+02:00
* fix(datepicker): fixed infinite cycle behavior * fix(modal): fix for issue-6683 body is scrollable if you close just one modal * fix(modal): fix for issue-6683 body is scrollable if you close just one modal * fix(modal): issue-6675 animation and issue-6547 * fix(modal): nested modals backdrop added * 18.1.3 * chore(versions): version bump * fix(datepicker): quick ranges button is not selected with maxDate (#6670) (#6698) Co-authored-by: Dmytro Danylov <daniloff200@gmail.com> * fix(docs): fixed typo in import --------- Co-authored-by: Dmytro Danylov <daniloff200@gmail.com>
diff --git a/apps/ngx-bootstrap-docs/src/assets/css/style.scss b/apps/ngx-bootstrap-docs/src/assets/css/style.scss
@@ -994,6 +994,10 @@ footer {
   border-radius: 4px;
 }
 
+.modal-backdrop ~ .modal + .modal {
+  background-color: rgba(0,0,0,0.5);
+}
+
 /*Imported adaptive styles*/
 @import "adaptive";
 
diff --git a/apps/ngx-bootstrap-docs/src/assets/json/current-version.json b/apps/ngx-bootstrap-docs/src/assets/json/current-version.json
@@ -1,3 +1,3 @@
 {
-  "version": "18.1.2"
+  "version": "18.1.3"
 }
diff --git a/libs/doc-pages/dropdown/src/lib/docs/usage.md b/libs/doc-pages/dropdown/src/lib/docs/usage.md
@@ -1,7 +1,7 @@
 ### Standalone component usage
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 
-import { BsDropdownModule } from 'ngx-bootstrap/datepicker';
+import { BsDropdownModule } from 'ngx-bootstrap/dropdown';
 
 @Components({
   standalone: true,
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap-base",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "license": "MIT",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "schematics": "./schematics/src/collection.json",
diff --git a/src/accordion/package.json b/src/accordion/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/accordion",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/alert/package.json b/src/alert/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/alert",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/buttons/package.json b/src/buttons/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/buttons",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/carousel/package.json b/src/carousel/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/carousel",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/chronos/package.json b/src/chronos/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/chronos",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/collapse/package.json b/src/collapse/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/collapse",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/component-loader/package.json b/src/component-loader/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/component-loader",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/datepicker/bs-datepicker-input.directive.ts b/src/datepicker/bs-datepicker-input.directive.ts
@@ -158,13 +158,13 @@ export class BsDatepickerInputDirective implements ControlValueAccessor, Validat
       if (this._picker && this._picker.minDate && isBefore(_value, this._picker.minDate, 'date')) {
         this.writeValue(this._picker.minDate);
 
-        return { bsDate: { minDate: this._picker.minDate } };
+        return this._picker.ignoreMinMaxErrors ? null : { bsDate: { minDate: this._picker.minDate } };
       }
 
       if (this._picker && this._picker.maxDate && isAfter(_value, this._picker.maxDate, 'date')) {
         this.writeValue(this._picker.maxDate);
 
-        return { bsDate: { maxDate: this._picker.maxDate } };
+        return this._picker.ignoreMinMaxErrors ? null : { bsDate: { maxDate: this._picker.maxDate } };
       }
     }
 
@@ -194,7 +194,6 @@ export class BsDatepickerInputDirective implements ControlValueAccessor, Validat
     }
 
     this._picker.bsValue = this._value;
-    this._onChange(this._value);
   }
 
   setDisabledState(isDisabled: boolean): void {
diff --git a/src/datepicker/bs-datepicker.component.ts b/src/datepicker/bs-datepicker.component.ts
@@ -72,6 +72,10 @@ export class BsDatepickerDirective implements OnInit, OnDestroy, OnChanges, Afte
    * Maximum date which is available for selection
    */
   @Input() maxDate?: Date;
+  /**
+   * Ignore validation errors when you reset to minDate or maxDate
+   */
+  @Input() ignoreMinMaxErrors?: boolean;
   /**
    * Minimum view mode : day, month, or year
    */
diff --git a/src/datepicker/package.json b/src/datepicker/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/datepicker",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/dropdown/package.json b/src/dropdown/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/dropdown",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/focus-trap/package.json b/src/focus-trap/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/focus-trap",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/locale/package.json b/src/locale/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/locale",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/mini-ngrx/package.json b/src/mini-ngrx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/mini-ngrx",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/modal/bs-modal.service.ts b/src/modal/bs-modal.service.ts
@@ -42,7 +42,7 @@ export class BsModalService {
   protected backdropRef?: ComponentRef<ModalBackdropComponent>;
   private _backdropLoader: ComponentLoader<ModalBackdropComponent>;
   private modalsCount = 0;
-  private lastHiddenId: number | string | undefined = 0;
+  private lastHiddenId: number | string | null | undefined = null;
   private lastDismissReason?: string;
 
   private loaders: ComponentLoader<ModalContainerComponent>[] = [];
@@ -69,6 +69,7 @@ export class BsModalService {
   ): BsModalRef<T> {
     this._focusEl = document.activeElement;
     this.modalsCount++;
+    this.lastHiddenId = null;
     this._createLoaders();
 
     // must be different per every show() call
@@ -146,7 +147,7 @@ export class BsModalService {
       .provide({ provide: BsModalRef, useValue: bsModalRef })
       .attach(ModalContainerComponent)
       .to('body');
-    bsModalRef.hide = () => this.hide(bsModalRef.id);
+    bsModalRef.hide = () => modalContainerRef.instance?.hide();
     bsModalRef.setClass = (newClass: string) => {
       if (modalContainerRef.instance) {
         modalContainerRef.instance.config.class = newClass;
diff --git a/src/modal/modal-container.component.ts b/src/modal/modal-container.component.ts
@@ -165,10 +165,11 @@ export class ModalContainerComponent implements OnInit, OnDestroy {
     );
     setTimeout(() => {
       this.isShown = false;
+      this.bsModalService?.hide(this.config.id);
       if (
         document &&
         document.body &&
-        this.bsModalService?.getModalsCount() === 1
+        this.bsModalService?.getModalsCount() === 0
       ) {
         this._renderer.removeClass(document.body, CLASS_NAME.OPEN);
         this._renderer.setStyle(document.body, 'overflow-y', '');
diff --git a/src/modal/package.json b/src/modal/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/modal",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/pagination/package.json b/src/pagination/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/pagination",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/popover/package.json b/src/popover/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/popover",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/positioning/package.json b/src/positioning/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/positioning",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/progressbar/package.json b/src/progressbar/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/progressbar",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/rating/package.json b/src/rating/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/rating",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/root/package.json b/src/root/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "description": "Angular Bootstrap",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT",
diff --git a/src/schematics/package.json b/src/schematics/package.json
@@ -1,6 +1,6 @@
 {
   "name": "schematics",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "schematics": "./collection.json",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
diff --git a/src/schematics/src/utils/current_dependency_versions.json b/src/schematics/src/utils/current_dependency_versions.json
@@ -1,4 +1,4 @@
 {
-  "NGX_BOOTSTRAP_VERSION": "18.1.2",
+  "NGX_BOOTSTRAP_VERSION": "18.1.3",
   "BOOTSTRAP_VERSION": "^5.2.3"
 }
diff --git a/src/sortable/package.json b/src/sortable/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/sortable",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/tabs/package.json b/src/tabs/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/tabs",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/timepicker/package.json b/src/timepicker/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/timepicker",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/tooltip/package.json b/src/tooltip/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/tooltip",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/typeahead/package.json b/src/typeahead/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/typeahead",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }
diff --git a/src/utils/package.json b/src/utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-bootstrap/utils",
-  "version": "18.1.2",
+  "version": "18.1.3",
   "author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
   "license": "MIT"
 }

Original file line number	Diff line number	Diff line change
`@@ -994,6 +994,10 @@ footer {`
`994`	`994`	`border-radius: 4px;`
`995`	`995`	`}`
`996`	`996`
	`997`	`+.modal-backdrop ~ .modal + .modal {`
	`998`	`+ background-color: rgba(0,0,0,0.5);`
	`999`	`+}`
	`1000`	`+`
`997`	`1001`	`/Imported adaptive styles/`
`998`	`1002`	`@import "adaptive";`
`999`	`1003`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "version": "18.1.2"`
	`2`	`+ "version": "18.1.3"`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ngx-bootstrap-base",`
`3`		`- "version": "18.1.2",`
	`3`	`+ "version": "18.1.3",`
`4`	`4`	`"license": "MIT",`
`5`	`5`	`"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",`
`6`	`6`	`"schematics": "./schematics/src/collection.json",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ngx-bootstrap/accordion",`
`3`		`- "version": "18.1.2",`
	`3`	`+ "version": "18.1.3",`
`4`	`4`	`"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",`
`5`	`5`	`"license": "MIT"`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ngx-bootstrap/alert",`
`3`		`- "version": "18.1.2",`
	`3`	`+ "version": "18.1.3",`
`4`	`4`	`"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",`
`5`	`5`	`"license": "MIT"`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ngx-bootstrap/buttons",`
`3`		`- "version": "18.1.2",`
	`3`	`+ "version": "18.1.3",`
`4`	`4`	`"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",`
`5`	`5`	`"license": "MIT"`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ngx-bootstrap/carousel",`
`3`		`- "version": "18.1.2",`
	`3`	`+ "version": "18.1.3",`
`4`	`4`	`"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",`
`5`	`5`	`"license": "MIT"`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ngx-bootstrap/chronos",`
`3`		`- "version": "18.1.2",`
	`3`	`+ "version": "18.1.3",`
`4`	`4`	`"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",`
`5`	`5`	`"license": "MIT"`
`6`	`6`	`}`