Merge pull request #120 from zioproto/fix/issue-119

Set socket_timeout default value to 5 seconds

Author: aiven-sal

valkey/asyncio/client.py

@@ -205,7 +205,7 @@ def __init__(
         port: int = 6379,
         db: Union[str, int] = 0,
         password: Optional[str] = None,
-        socket_timeout: Optional[float] = None,
+        socket_timeout: Optional[float] = 5,
         socket_connect_timeout: Optional[float] = None,
         socket_keepalive: Optional[bool] = None,
         socket_keepalive_options: Optional[Mapping[int, Union[int, bytes]]] = None,

valkey/asyncio/cluster.py

@@ -259,7 +259,7 @@ def __init__(
         socket_connect_timeout: Optional[float] = None,
         socket_keepalive: bool = False,
         socket_keepalive_options: Optional[Mapping[int, Union[int, bytes]]] = None,
-        socket_timeout: Optional[float] = None,
+        socket_timeout: Optional[float] = 5,
         retry: Optional["Retry"] = None,
         retry_on_error: Optional[List[Type[Exception]]] = None,
         # SSL related kwargs

valkey/asyncio/connection.py

@@ -136,7 +136,7 @@ def __init__(
         *,
         db: Union[str, int] = 0,
         password: Optional[str] = None,
-        socket_timeout: Optional[float] = None,
+        socket_timeout: Optional[float] = 5,
         socket_connect_timeout: Optional[float] = None,
         retry_on_timeout: bool = False,
         retry_on_error: Union[list, _Sentinel] = SENTINEL,

valkey/connection.py

@@ -137,7 +137,7 @@ def __init__(
         self,
         db: int = 0,
         password: Optional[str] = None,
-        socket_timeout: Optional[float] = None,
+        socket_timeout: Optional[float] = 5,
         socket_connect_timeout: Optional[float] = None,
         retry_on_timeout: bool = False,
         retry_on_error=SENTINEL,