fix: replace $ in typenames in classgraph symbol processor (#879)

Author: piiertho

harness/tests/src/main/kotlin/godot/tests/constructor/ConstructorRegistrationTest.kt

@@ -2,6 +2,14 @@ package godot.tests.constructor
 
 import godot.api.Node
 import godot.annotation.RegisterClass
+import godot.annotation.RegisterProperty
 
 @RegisterClass
-class ConstructorRegistrationTest(): Node()
+class ConstructorRegistrationTest(): Node() {
+    @RegisterProperty
+    var defaultConstructorHasBeenCalled = false
+
+    init {
+        defaultConstructorHasBeenCalled = true
+    }
+}

harness/tests/test/unit/test_call_scala_class.gd.uid

@@ -0,0 +1 @@
+uid://bqpi0f06bv3xl

harness/tests/test/unit/test_constructor_args.gd

@@ -2,16 +2,6 @@ extends "res://addons/gut/test.gd"
 
 
 func test_should_call_default_constructor() -> void:
-	var test_instance = MultiArgsConstructorTest.new()
-	assert_true(test_instance.default_constructor_has_been_called, "Default constructor should have been called")
-	test_instance.free()
-
-func test_should_call_one_arg_constructor() -> void:
-	var test_instance = load("res://scripts/godot/tests/MultiArgsConstructorTest.gdj").new(42)
-	assert_true(test_instance.one_arg_constructor_has_been_called, "One arg constructor should have been called")
-	test_instance.free()
-
-func test_should_call_three_args_constructor() -> void:
-	var test_instance = load("res://scripts/godot/tests/MultiArgsConstructorTest.gdj").new(42, "hello")
-	assert_true(test_instance.three_args_constructor_has_been_called, "Three args constructor should have been called")
-	test_instance.free()
+    var test_instance = ConstructorRegistrationTest.new()
+    assert_true(test_instance.default_constructor_has_been_called, "Default constructor should have been called")
+    test_instance.free()

harness/tests/test/unit/test_constructor_args.gd.uid

@@ -166,7 +166,7 @@ internal fun ClassInfo.mapToType(typeArguments: List<TypeArgument>, settings: Se
         .toList()
 
     return Type(
-        fqName = name,
+        fqName = name.replace("$", "."),
         kind = typeKind,
         supertypes = superTypes,
         arguments = { typeArguments.map { it.getType(settings) } },

harness/tests/test/unit/test_constructors.gd

@@ -146,45 +146,6 @@ class ClassBuilderDsl<T : KtObject>(
         )
     }
 
-    inline fun <reified P : Enum<P>> enumProperty(
-        name: String,
-        noinline getter: (T) -> P,
-        noinline setter: (T, P) -> Unit,
-        usage: Long,
-        hintString: String
-    ) {
-        require(!properties.contains(name)) {
-            "Found two properties with name $name for class $registeredName"
-        }
-
-        properties[name] = KtEnumProperty(
-            KtPropertyInfo(
-                VariantParser.LONG,
-                name,
-                "Int",
-                PropertyHint.ENUM,
-                hintString,
-                usage,
-            ),
-            getter,
-            setter,
-            { enum: P? -> enum?.ordinal ?: 1 },
-            { i -> enumValues<P>()[i] }
-        )
-    }
-
-    inline fun <reified P : Enum<P>> enumProperty(
-        kProperty: KMutableProperty1<T, P>,
-        usage: Long,
-        hintString: String
-    ) = enumProperty(
-        kProperty.name.convertToSnakeCase(),
-        { instance: T -> kProperty.get(instance) },
-        { instance: T, p: P -> kProperty.set(instance, p) },
-        usage,
-        hintString
-    )
-
     inline fun <reified P : Enum<P>, L : Collection<P>> enumListProperty(
         name: String,
         noinline getter: (T) -> L,