some more cleanup

Author: Pazus

src/test/java/org/utplsql/api/VersionObjectTest.java

@@ -15,7 +15,7 @@ void versionPatternRecognitionFull() {
         assertEquals(1, (long)v.getMinor());
         assertEquals(3, (long)v.getBugfix());
         assertEquals(1234, (long)v.getBuild());
-        assertEquals(true, v.isValid());
+        assertTrue(v.isValid());
         assertEquals("3.1.3.1234", v.getNormalizedString());
     }
 
@@ -39,7 +39,7 @@ void versionPatternRecognitionPartial() {
         assertEquals(1, (long)v.getMinor());
         assertNull(v.getBugfix());
         assertNull(v.getBuild());
-        assertEquals(true, v.isValid());
+        assertTrue(v.isValid());
         assertEquals("3.1", v.getNormalizedString());
     }
 
@@ -51,7 +51,7 @@ void versionPatternRecognitionInvalid() {
         assertNull(v.getMinor());
         assertNull(v.getBugfix());
         assertNull(v.getBuild());
-        assertEquals(false, v.isValid());
+        assertFalse(v.isValid());
         assertEquals("invalid", v.getNormalizedString());
     }
 
@@ -80,29 +80,24 @@ void versionCompareTo()
     }
 
     @Test
-    void isGreaterOrEqualThan()
+    void isGreaterOrEqualThan() throws InvalidVersionException
     {
         Version base = Version.create("2.3.4.5");
 
-        try {
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("1")));
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("2")));
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("2.3")));
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("2.2")));
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("2.3.4")));
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("2.3.3")));
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("2.3.4.5")));
-            assertEquals(true, base.isGreaterOrEqualThan(Version.create("2.3.4.4")));
-
-            assertEquals(false, base.isGreaterOrEqualThan(Version.create("2.3.4.6")));
-            assertEquals(false, base.isGreaterOrEqualThan(Version.create("2.3.5")));
-            assertEquals(false, base.isGreaterOrEqualThan(Version.create("2.4")));
-            assertEquals(false, base.isGreaterOrEqualThan(Version.create("3")));
-        }
-        catch ( InvalidVersionException e )
-        {
-            fail(e);
-        }
+        assertTrue(base.isGreaterOrEqualThan(Version.create("1")));
+        assertTrue(base.isGreaterOrEqualThan(Version.create("2")));
+        assertTrue(base.isGreaterOrEqualThan(Version.create("2.3")));
+        assertTrue(base.isGreaterOrEqualThan(Version.create("2.2")));
+        assertTrue(base.isGreaterOrEqualThan(Version.create("2.3.4")));
+        assertTrue(base.isGreaterOrEqualThan(Version.create("2.3.3")));
+        assertTrue(base.isGreaterOrEqualThan(Version.create("2.3.4.5")));
+        assertTrue(base.isGreaterOrEqualThan(Version.create("2.3.4.4")));
+
+        assertFalse(base.isGreaterOrEqualThan(Version.create("2.3.4.6")));
+        assertFalse(base.isGreaterOrEqualThan(Version.create("2.3.5")));
+        assertFalse(base.isGreaterOrEqualThan(Version.create("2.4")));
+        assertFalse(base.isGreaterOrEqualThan(Version.create("3")));
+
     }
 
     @Test
@@ -113,23 +108,23 @@ void isGreaterOrEqualThanFails()
             Version.create("2.3.4.5").isGreaterOrEqualThan(Version.create("aerfvf"));
             fail("Given Version is invalid - not recognized");
         }
-        catch ( InvalidVersionException e ) {
+        catch ( InvalidVersionException ignored ) {
         }
 
         // Base version is invalid
         try {
             Version.create("erefs").isGreaterOrEqualThan(Version.create("1.2.3"));
             fail("Base version is invalid - not recognized");
         }
-        catch ( InvalidVersionException e ) {
+        catch ( InvalidVersionException ignored ) {
         }
 
         // Both versions are invalid
         try {
             Version.create("erefs").isGreaterOrEqualThan(Version.create("aerfvf"));
             fail("Both versions are invalid - not recognized");
         }
-        catch ( InvalidVersionException e ) {
+        catch ( InvalidVersionException ignored ) {
         }
     }
 }