address inspection warnings

Author: Pazus

src/main/java/org/utplsql/api/JavaApiVersionInfo.java

@@ -4,10 +4,6 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
-import java.net.URISyntaxException;
-import java.nio.charset.Charset;
-import java.nio.file.Files;
-import java.nio.file.Paths;
 
 /** This class is getting updated automatically by the build process.
  * Please do not update its constants manually cause they will be overwritten.
@@ -25,11 +21,9 @@ private JavaApiVersionInfo() { }
     static {
         try {
 
-            try ( InputStream in = JavaApiVersionInfo.class.getClassLoader().getResourceAsStream("utplsql-api.version")) {
-                BufferedReader reader = new BufferedReader(new InputStreamReader(in));
+            try ( InputStream in = JavaApiVersionInfo.class.getClassLoader().getResourceAsStream("utplsql-api.version");
+                  BufferedReader reader = new BufferedReader(new InputStreamReader(in))) {
                 MAVEN_PROJECT_VERSION = reader.readLine();
-
-                reader.close();
             }
         }
         catch ( IOException e ) {

src/main/java/org/utplsql/api/TestRunner.java

@@ -5,7 +5,6 @@
 import org.utplsql.api.compatibility.CompatibilityProxy;
 import org.utplsql.api.db.DatabaseInformation;
 import org.utplsql.api.db.DefaultDatabaseInformation;
-import org.utplsql.api.exception.DatabaseNotCompatibleException;
 import org.utplsql.api.exception.SomeTestsFailedException;
 import org.utplsql.api.exception.UtPLSQLNotInstalledException;
 import org.utplsql.api.reporter.DocumentationReporter;

src/main/java/org/utplsql/api/Version.java

@@ -37,7 +37,7 @@ public class Version implements Comparable<Version> {
     private final Integer build;
     private final boolean valid;
 
-    private Version(String origString, Integer major, Integer minor, Integer bugfix, Integer build, boolean valid) {
+    private Version(String origString, @Nullable Integer major, @Nullable Integer minor, @Nullable Integer bugfix, @Nullable Integer build, boolean valid) {
         this.origString = origString;
         this.major = major;
         this.minor = minor;
@@ -109,18 +109,22 @@ public String toString() {
         return origString;
     }
 
+    @Nullable
     public Integer getMajor() {
         return major;
     }
 
+    @Nullable
     public Integer getMinor() {
         return minor;
     }
 
+    @Nullable
     public Integer getBugfix() {
         return bugfix;
     }
 
+    @Nullable
     public Integer getBuild() {
         return build;
     }

src/main/java/org/utplsql/api/compatibility/CompatibilityProxy.java

@@ -28,7 +28,7 @@ public class CompatibilityProxy {
 
     private Version databaseVersion;
     private boolean compatible = false;
-    private DatabaseInformation databaseInformation;
+    private final DatabaseInformation databaseInformation;
 
     public CompatibilityProxy( Connection conn ) throws SQLException {
         this(conn, false, null);

src/main/java/org/utplsql/api/exception/DatabaseNotCompatibleException.java

@@ -25,7 +25,7 @@ public DatabaseNotCompatibleException( String message, Version clientVersion, Ve
 
     public DatabaseNotCompatibleException( Version clientVersion, Version databaseVersion, Throwable cause )
     {
-        this("utPLSQL API (" + String.valueOf(clientVersion) + ") not compatible with database (" + String.valueOf(databaseVersion) + ")", clientVersion, databaseVersion, cause);
+        this("utPLSQL API (" + clientVersion + ") not compatible with database (" + databaseVersion + ")", clientVersion, databaseVersion, cause);
     }
 
     public DatabaseNotCompatibleException( Version clientVersion, Version databaseVersion )

src/main/java/org/utplsql/api/testRunner/AbstractTestRunnerStatement.java

@@ -21,7 +21,7 @@
 abstract class AbstractTestRunnerStatement implements TestRunnerStatement {
 
     protected final TestRunnerOptions options;
-    protected final Connection conn;
+    private final Connection conn;
     protected final CallableStatement callableStatement;
 
     public AbstractTestRunnerStatement(TestRunnerOptions options, Connection conn) throws SQLException {

src/test/java/org/utplsql/api/JavaApiVersionTest.java

@@ -4,7 +4,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-public class JavaApiVersionTest {
+class JavaApiVersionTest {
 
     @Test
     void getJavaApiVersion() {

src/test/java/org/utplsql/api/OutputBufferIT.java

@@ -27,7 +27,7 @@
  */
 class OutputBufferIT extends AbstractDatabaseTest {
 
-    public Reporter createReporter() throws SQLException {
+    private Reporter createReporter() throws SQLException {
         Reporter reporter = new DocumentationReporter().init(newConnection());
         System.out.println("Reporter ID: " + reporter.getId());
         return reporter;