Improvement of tests

Author: pesse

src/test/java/org/utplsql/cli/DataSourceProviderIT.java

@@ -20,6 +20,14 @@ void connectToDatabase() throws SQLException {
         assertNotNull(dataSource);
     }
 
+    //@Test
+    void connectAsSysdba() throws SQLException {
+        ConnectionConfig config = new ConnectionConfig("sys as sysdba/oracle@localhost:1522/ORCLPDB1");
+        DataSource dataSource = new TestedDataSourceProvider(config).getDataSource();
+
+        assertNotNull(dataSource);
+    }
+
     @Test
     void initNlsLang() throws SQLException {
         System.setProperty("NLS_LANG", "BRAZILIAN PORTUGUESE_BRAZIL.WE8ISO8859P1");

src/test/java/org/utplsql/cli/RunCommandIT.java

@@ -5,6 +5,7 @@
 import org.utplsql.api.reporter.CoreReporters;
 
 import java.nio.file.Paths;
+import java.sql.SQLException;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
@@ -13,6 +14,14 @@
  */
 class RunCommandIT extends AbstractFileOutputTest {
 
+    private void assertValidReturnCode(int returnCode) throws SQLException {
+        // Only expect failure-exit-code to work on several framework versions
+        if (OptionalFeatures.FAIL_ON_ERROR.isAvailableFor(TestHelper.getFrameworkVersion()))
+            assertEquals(2, returnCode);
+        else
+            assertEquals(0, returnCode);
+    }
+
     @Test
     void run_Default() throws Exception {
 
@@ -23,21 +32,18 @@ void run_Default() throws Exception {
                 "-c",
                 "--failure-exit-code=2");
 
-        // Only expect failure-exit-code to work on several framework versions
-        if (OptionalFeatures.FAIL_ON_ERROR.isAvailableFor(TestHelper.getFrameworkVersion()))
-            assertEquals(2, result);
-        else
-            assertEquals(0, result);
+        assertValidReturnCode(result);
     }
 
     @Test
     void run_Debug() throws Exception {
 
         int result = TestHelper.runApp("run",
                 TestHelper.getConnectionString(),
-                "--debug");
+                "--debug",
+                "--failure-exit-code=2");
 
-        assertEquals(1, result);
+        assertValidReturnCode(result);
     }
 
     @Test
@@ -55,11 +61,7 @@ void run_MultipleReporters() throws Exception {
                 "-c",
                 "--failure-exit-code=2");
 
-        // Only expect failure-exit-code to work on several framework versions
-        if (OptionalFeatures.FAIL_ON_ERROR.isAvailableFor(TestHelper.getFrameworkVersion()))
-            assertEquals(2, result);
-        else
-            assertEquals(0, result);
+        assertValidReturnCode(result);
     }
 
 

src/test/java/org/utplsql/cli/TestHelper.java

@@ -45,4 +45,16 @@ static Version getFrameworkVersion() throws SQLException {
     static String getConnectionString() {
         return sUser + "/" + sPass + "@" + sUrl;
     }
+
+    static String getUser() {
+        return sUser;
+    }
+
+    static String getPass() {
+        return sPass;
+    }
+
+    static String getUrl() {
+        return sUrl;
+    }
 }