made properties final

Author: Pazus

src/main/java/org/utplsql/cli/CommandProvider.java

@@ -8,17 +8,15 @@
 
 public class CommandProvider {
 
-    private Map<String, ICommand> commands;
-    private JCommander jCommander;
+    private final Map<String, ICommand> commands = new HashMap<>();
+    private final JCommander jCommander;
 
     public CommandProvider( JCommander jCommander ) {
         this.jCommander = jCommander;
         init();
     }
 
     private void init() {
-        commands = new HashMap<>();
-
         addCommand(new RunCommand());
         addCommand(new VersionInfoCommand());
         addCommand(new ReportersCommand());

src/main/java/org/utplsql/cli/ConnectionInfo.java

@@ -5,7 +5,7 @@
 public class ConnectionInfo {
 
     public static final String COMMANDLINE_PARAM_DESCRIPTION = "<user>/<password>@//<host>[:<port>]/<service> OR <user>/<password>@<TNSName> OR <user>/<password>@<host>:<port>:<SID>";
-    private String connectionInfo;
+    private final String connectionInfo;
 
     public ConnectionInfo(String connectionInfo) {
         this.connectionInfo = connectionInfo;

src/main/java/org/utplsql/cli/HelpCommand.java

@@ -7,11 +7,12 @@
  */
 public class HelpCommand implements ICommand {
 
-    private String errorMessage;
-    private JCommander jCommander;
+    private final String errorMessage;
+    private final JCommander jCommander;
 
     public HelpCommand(JCommander jCommander) {
         this.jCommander = jCommander;
+        this.errorMessage = null;
     }
 
     public HelpCommand( JCommander jCommander, String errorMessage ) {

src/main/java/org/utplsql/cli/ReporterManager.java

@@ -118,5 +118,5 @@ public List<ReporterOptions> getReporterOptionsList() {
         return reporterOptionsList;
     }
 
-    public int getNumberOfReporters() { return reporterOptionsList.size(); };
+    public int getNumberOfReporters() { return reporterOptionsList.size(); }
 }

src/main/java/org/utplsql/cli/datasource/TestedDataSourceProvider.java

@@ -23,7 +23,7 @@ interface ConnectStringPossibility {
 
     private static final Logger logger = LoggerFactory.getLogger(TestedDataSourceProvider.class);
     private final ConnectionConfig config;
-    private List<ConnectStringPossibility> possibilities = new ArrayList<>();
+    private final List<ConnectStringPossibility> possibilities = new ArrayList<>();
 
     public TestedDataSourceProvider(ConnectionConfig config) {
         this.config = config;

src/main/java/org/utplsql/cli/log/StringBlockFormatter.java

@@ -3,7 +3,7 @@
 public class StringBlockFormatter {
 
     private String headline;
-    private StringBuilder content = new StringBuilder();
+    private final StringBuilder content = new StringBuilder();
 
     public StringBlockFormatter() {}