fix minor typos. update code skipped by conditional compilation. make resource access class for netcore a designer file to be ignored by stylecop. update unit tests to match stylecop rules for monotouch

Author: fsimonazzi

source/Unity.Interception/Src/Interceptors/InstanceInterceptors/InterfaceInterception/InterfaceInterceptorClassGenerator.Desktop.cs

@@ -11,7 +11,7 @@ private static ModuleBuilder GetModuleBuilder()
         {
             string moduleName = Guid.NewGuid().ToString("N");
 #if DEBUG_SAVE_GENERATED_ASSEMBLY
-            return assemblyBuilder.DefineDynamicModule(moduleName, moduleName + ".dll", true);
+            return AssemblyBuilder.DefineDynamicModule(moduleName, moduleName + ".dll", true);
 #else
             return AssemblyBuilder.DefineDynamicModule(moduleName);
 #endif

source/Unity.Interception/Src/Interceptors/TypeInterceptors/VirtualMethodInterception/InterceptingClassGeneration/InterceptingClassGenerator.Desktop.cs

@@ -11,7 +11,7 @@ private static ModuleBuilder GetModuleBuilder()
         {
             string moduleName = Guid.NewGuid().ToString("N");
 #if DEBUG_SAVE_GENERATED_ASSEMBLY
-            return assemblyBuilder.DefineDynamicModule(moduleName, moduleName + ".dll", true);
+            return AssemblyBuilder.DefineDynamicModule(moduleName, moduleName + ".dll", true);
 #else
             return AssemblyBuilder.DefineDynamicModule(moduleName);
 #endif

source/Unity/Src/GlobalSuppressions.cs

@@ -3,11 +3,4 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: SuppressMessage("Microsoft.Design", "CA2210:AssembliesShouldHaveValidStrongNames", Justification = "Strong name is supplied in build process.")]
-[assembly: SuppressMessage("Microsoft.Usage", "CA2209:AssembliesShouldDeclareMinimumSecurity")]
-[assembly: SuppressMessage("Microsoft.Usage", "CA2214:DoNotCallOverridableMethodsInConstructors", Scope = "member", Target = "Microsoft.Practices.Unity.UnityContainer..ctor()")]
-[assembly: SuppressMessage("Microsoft.Usage", "CA2214:DoNotCallOverridableMethodsInConstructors", Scope = "member", Target = "Microsoft.Practices.Unity.UnityContainer..ctor(Microsoft.Practices.Unity.UnityContainer)")]
-[assembly: SuppressMessage("Microsoft.Design", "CA1062:ValidateArgumentsOfPublicMethods", Scope = "member", Target = "Microsoft.Practices.Unity.ResolutionFailedException..ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)")]
-[assembly: SuppressMessage("Microsoft.Reliability", "CA2000:DisposeObjectsBeforeLosingScope", Scope = "member", Target = "Microsoft.Practices.Unity.UnityContainerBase.RegisterInstance(System.Type,System.Object):Microsoft.Practices.Unity.IUnityContainer")]
-[assembly: SuppressMessage("Microsoft.Reliability", "CA2000:DisposeObjectsBeforeLosingScope", Scope = "member", Target = "Microsoft.Practices.Unity.UnityContainerBase.RegisterInstance(System.Type,System.String,System.Object):Microsoft.Practices.Unity.IUnityContainer")]
-[assembly: SuppressMessage("Microsoft.Design", "CA1062:ValidateArgumentsOfPublicMethods", Scope = "member", Target = "Microsoft.Practices.Unity.InjectionParameter..ctor(System.Object)")]
 [assembly: SuppressMessage("Microsoft.Design", "CA1020:AvoidNamespacesWithFewTypes", Scope = "namespace", Target = "Microsoft.Practices.Unity.StaticFactory", Justification = "As designed")]

source/Unity/Src/ObjectBuilder/RecoveryStack.cs

@@ -10,7 +10,7 @@ namespace Microsoft.Practices.ObjectBuilder2
     /// An implementation of <see cref="IRecoveryStack"/>.
     /// </summary>
     [SuppressMessage("Microsoft.Naming", "CA1711:IdentifiersShouldNotHaveIncorrectSuffix", 
-        Justification = "The name ends in stack becuase the semantics are a stack, and we want that to be obvious to users")]
+        Justification = "The name ends in stack because the semantics are a stack, and we want that to be obvious to users")]
     public class RecoveryStack : IRecoveryStack
     {
         private Stack<IRequiresRecovery> recoveries = new Stack<IRequiresRecovery>();

source/Unity/Src/ObjectBuilder/Strategies/BuildPlan/DynamicMethod/DynamicBuildPlanGenerationContext.cs

@@ -73,8 +73,8 @@ public void AddToBuildPlan(Expression expression)
         /// <returns></returns>
         public Expression CreateParameterExpression(IDependencyResolverPolicy resolver, Type parameterType, Expression setOperationExpression)
         {
-            // The intent of this is to create a parameter resolving expression block.  The following
-            // psuedo code will hopefully make it clearer as to what we're trying to accomplish (of course actual code
+            // The intent of this is to create a parameter resolving expression block. The following
+            // pseudo code will hopefully make it clearer as to what we're trying to accomplish (of course actual code
             // trumps comments):
             //  object priorOperation = context.CurrentOperation;
             //  SetCurrentOperation

source/Unity/Src/RegistrationByConvention/Resources.NetCore.cs renamed to source/Unity/Src/RegistrationByConvention/Resources.NetCore.Designer.cs

@@ -7,7 +7,7 @@
 <#@ import namespace="System.Text" #>
 <#@ import namespace="System.Text.RegularExpressions" #>
 <#@ import namespace="System.Collections.Generic" #>
-<#@ output extension=".cs" #>
+<#@ output extension=".Designer.cs" #>
 <#
 	var resourceFile = this.Host.ResolvePath("strings\\en-US\\Resources.resw");
 	XDocument document = XDocument.Load(resourceFile);
@@ -37,7 +37,7 @@ namespace <#= suggestedNamespace #>
 
         private static global::Windows.ApplicationModel.Resources.ResourceLoader resourceMan;
 
-        [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
+        [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode", Justification = "Using resx generated code as template")]
         internal Resources()
         {
         }

source/Unity/Src/RegistrationByConvention/Resources.NetCore.tt

@@ -53,7 +53,7 @@
     <Compile Include="DuplicateTypeMappingException.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="RegistrationConvention.cs" />
-    <Compile Include="Resources.NetCore.cs">
+    <Compile Include="Resources.NetCore.Designer.cs">
       <AutoGen>True</AutoGen>
       <DesignTime>True</DesignTime>
       <DependentUpon>Resources.NetCore.tt</DependentUpon>
@@ -73,7 +73,7 @@
     <None Include="packages.Unity.RegistrationByConvention.NetCore.config" />
     <None Include="Resources.NetCore.tt">
       <Generator>TextTemplatingFileGenerator</Generator>
-      <LastGenOutput>Resources.NetCore.cs</LastGenOutput>
+      <LastGenOutput>Resources.NetCore.Designer.cs</LastGenOutput>
     </None>
     <PRIResource Include="strings\en-US\Resources.resw" />
   </ItemGroup>

source/Unity/Src/RegistrationByConvention/Unity.RegistrationByConvention.NetCore.csproj

@@ -5,8 +5,8 @@
 #elif __IOS__
 using NUnit.Framework;
 using TestClassAttribute = NUnit.Framework.TestFixtureAttribute;
-using TestMethodAttribute = NUnit.Framework.TestAttribute;
 using TestInitializeAttribute = NUnit.Framework.SetUpAttribute;
+using TestMethodAttribute = NUnit.Framework.TestAttribute;
 #else
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 #endif

source/Unity/Tests/ObjectBuilder/BuildKeyMappingPolicyTest.cs

@@ -6,8 +6,8 @@
 #elif __IOS__
 using NUnit.Framework;
 using TestClassAttribute = NUnit.Framework.TestFixtureAttribute;
-using TestMethodAttribute = NUnit.Framework.TestAttribute;
 using TestInitializeAttribute = NUnit.Framework.SetUpAttribute;
+using TestMethodAttribute = NUnit.Framework.TestAttribute;
 #else
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 #endif