remove local build helper scripts for now, update Theme editor to handle read only install location, modify safepath to handle any folder name

Author: unitycoder

InstallerBumpVersion.bat

@@ -43,7 +43,7 @@ public partial class MainWindow : Window
         public static readonly string projectNameFile = "ProjectName.txt";
         public static string preferredVersion = null;
         public static int projectNameSetting = 0; // 0 = folder or ProjectName.txt if exists, 1=ProductName
-        public static readonly string initScriptFileFullPath = GetInitScriptPath();
+        public static readonly string initScriptFileFullPath = Tools.GetSafeFilePath("Scripts", "InitializeProject.cs");
 
         const string contextRegRoot = "Software\\Classes\\Directory\\Background\\shell";
         const string githubURL = "https://github.com/unitycoder/UnityLauncherPro";
@@ -2724,51 +2724,52 @@ private void MenuItemBrowsePersistentDataPath_Click(object sender, RoutedEventAr
             }
         }
 
-        void ApplyTheme(string themeFile)
+        private void ApplyTheme(string themeFileName)
         {
-            if (chkUseCustomTheme.IsChecked == false) return;
-
-            //Console.WriteLine("Load theme: " + themefile);
+            if (chkUseCustomTheme.IsChecked != true)
+                return;
 
-            themeFile = "Themes/" + themeFile;
+            // 1) Compute the full, safe path to the INI
+            string themePath = Tools.GetSafeFilePath("Themes", themeFileName);
 
-            if (File.Exists(themeFile) == true)
+            // 2) Try to load it
+            if (File.Exists(themePath))
             {
-                var colors = File.ReadAllLines(themeFile);
-
-                // parse lines
-                for (int i = 0, length = colors.Length; i < length; i++)
+                var lines = File.ReadAllLines(themePath);
+                for (int i = 0; i < lines.Length; i++)
                 {
-                    // skip comments
-                    if (colors[i].IndexOf('#') == 0) continue;
-                    // split row (name and color)
-                    var row = colors[i].Split('=');
-                    // skip bad rows
-                    if (row.Length != 2) continue;
-
-                    // parse color
+                    string line = lines[i].Trim();
+                    // skip empty or comment
+                    if (string.IsNullOrEmpty(line) || line.StartsWith("#"))
+                        continue;
+
+                    var parts = line.Split(new[] { '=' }, 2);
+                    if (parts.Length != 2)
+                        continue;
+
+                    string key = parts[0].Trim();
+                    string value = parts[1].Trim();
+
                     try
                     {
-                        //Console.WriteLine(row[0] +"="+ row[1].Trim());
-                        var col = new BrushConverter().ConvertFrom(row[1].Trim());
-                        // apply color
-                        Application.Current.Resources[row[0]] = (SolidColorBrush)col;
+                        var brush = (SolidColorBrush)new BrushConverter().ConvertFrom(value);
+                        Application.Current.Resources[key] = brush;
                     }
-                    catch (Exception e)
+                    catch (Exception ex)
                     {
-                        Console.WriteLine(e);
-                        SetStatus("Failed to parse color value: " + row[1]);
+                        Console.WriteLine(ex);
+                        SetStatus($"Failed to parse color value: {value}");
                     }
-
                 }
             }
             else
             {
-                Console.WriteLine("Theme file not found: " + themeFile);
-                SetStatus("Theme file not found: " + themeFile);
+                Console.WriteLine($"Theme file not found: {themePath}");
+                SetStatus($"Theme file not found: {themePath}");
             }
         }
 
+
         void ResetTheme()
         {
             foreach (DictionaryEntry item in Application.Current.Resources.MergedDictionaries[0])
@@ -2809,8 +2810,8 @@ private void BtnReloadTheme_Click(object sender, RoutedEventArgs e)
         private void TxtCustomThemeFile_LostFocus(object sender, RoutedEventArgs e)
         {
             var s = (TextBox)sender;
-            Properties.Settings.Default.themeFile = s.Text;
-            Properties.Settings.Default.Save();
+            Settings.Default.themeFile = s.Text;
+            Settings.Default.Save();
         }
 
         private void TxtCustomThemeFile_PreviewKeyDown(object sender, KeyEventArgs e)
@@ -4105,31 +4106,6 @@ private void btnPurgeMissingFolders_Click(object sender, RoutedEventArgs e)
             SetStatus("Purged " + removedCount + " items", MessageType.Info);
         }
 
-        // to handle folders where user has no write access ()
-        private static string GetInitScriptPath()
-        {
-            string preferredDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Scripts");
-            string fallbackDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "UnityLauncherPro", "Scripts");
-
-            try
-            {
-                Directory.CreateDirectory(preferredDir); // safe even if it exists
-                return Path.Combine(preferredDir, "InitializeProject.cs");
-            }
-            catch (UnauthorizedAccessException)
-            {
-                // No write permission in Program Files etc.
-            }
-            catch (Exception ex)
-            {
-                // Optional: log other unexpected errors
-                Console.WriteLine("Init folder fallback: " + ex.Message);
-            }
-
-            Directory.CreateDirectory(fallbackDir); // always safe
-            return Path.Combine(fallbackDir, "InitializeProject.cs");
-        }
-
         //private void menuProjectProperties_Click(object sender, RoutedEventArgs e)
         //{
         //    var proj = GetSelectedProject();

InstallerGUIDGen.vbs

@@ -109,35 +109,47 @@ private void GridThemeColors_SelectionChanged(object sender, SelectionChangedEve
 
         private void BtnSaveTheme_Click(object sender, RoutedEventArgs e)
         {
-            var themeFolder = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Themes");
-
-            if (Directory.Exists(themeFolder) == false) Directory.CreateDirectory(themeFolder);
-
-            SaveFileDialog saveFileDialog = new SaveFileDialog();
-            if (string.IsNullOrEmpty(previousSaveFileName))
-            {
-                saveFileDialog.FileName = "custom";
-            }
-            else
+            // 1) Determine the default filename (with .ini)
+            string defaultName = string.IsNullOrEmpty(previousSaveFileName)
+                ? "custom.ini"
+                : previousSaveFileName + ".ini";
+
+            // 2) Ask the helper for a safe full path
+            string initialFullPath = Tools.GetSafeFilePath("Themes", defaultName);
+            string initialDir = Path.GetDirectoryName(initialFullPath);
+            string initialFile = Path.GetFileNameWithoutExtension(initialFullPath);
+
+            // 3) Configure the save dialog
+            var saveFileDialog = new SaveFileDialog
             {
-                saveFileDialog.FileName = previousSaveFileName;
-            }
-            saveFileDialog.DefaultExt = ".ini";
-            saveFileDialog.Filter = "Theme files (.ini)|*.ini";
-            saveFileDialog.InitialDirectory = themeFolder;
-            saveFileDialog.RestoreDirectory = true;
-
+                FileName = initialFile,   // no extension here
+                DefaultExt = ".ini",
+                Filter = "Theme files (.ini)|*.ini",
+                InitialDirectory = initialDir,
+                RestoreDirectory = true
+            };
+
+            // 4) Show and, if confirmed, write out the INI
             if (saveFileDialog.ShowDialog() == true)
             {
-                List<string> iniRows = new List<string>();
-                iniRows.Add("# Created with UnityLauncherPro built-in theme editor " + DateTime.Now.ToString("dd/MM/yyyy"));
+                // Build INI lines
+                var iniRows = new List<string>
+        {
+            "# Created with UnityLauncherPro built-in theme editor "
+              + DateTime.Now.ToString("dd/MM/yyyy")
+        };
+                // original-style loop
                 for (int i = 0; i < themeColors.Count; i++)
                 {
                     iniRows.Add(themeColors[i].Key + "=" + themeColors[i].Brush.ToString());
                 }
 
-                var themePath = saveFileDialog.FileName;
+                // Get the chosen path & ensure its folder exists
+                string themePath = saveFileDialog.FileName;
                 previousSaveFileName = Path.GetFileNameWithoutExtension(themePath);
+                Directory.CreateDirectory(Path.GetDirectoryName(themePath));
+
+                // Write out
                 File.WriteAllLines(themePath, iniRows);
                 Console.WriteLine("Saved theme: " + themePath);
             }

UnityLauncherPro/MainWindow.xaml.cs

@@ -2779,7 +2779,42 @@ internal static bool RunExclusionElevated(IEnumerable<string> paths, bool silent
             return true;
         }
 
+        /// <summary>
+        /// Returns a full file path under either the application's install folder
+        /// or, if that isn't writable, under LocalAppData\UnityLauncherPro\<subfolder>.
+        /// </summary>
+        /// <param name="subfolder">e.g. "Themes", "Scripts"</param>
+        /// <param name="fileName">e.g. "custom.ini", "InitializeProject.cs"</param>
+        public static string GetSafeFilePath(string subfolder, string fileName)
+        {
+            // 1) Preferred: under the app folder
+            string preferredDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, subfolder);
+            // 2) Fallback: in LocalAppData
+            string fallbackDir = Path.Combine(
+                Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
+                "UnityLauncherPro",
+                subfolder);
+
+            try
+            {
+                // Safe even if it already exists
+                Directory.CreateDirectory(preferredDir);
+                return Path.Combine(preferredDir, fileName);
+            }
+            catch (UnauthorizedAccessException)
+            {
+                // no write access under Program Files
+            }
+            catch (Exception ex)
+            {
+                // optional: log unexpected errors
+                Console.WriteLine($"Warning: couldn’t create {preferredDir}: {ex.Message}");
+            }
 
+            // Ensure fallback always exists
+            Directory.CreateDirectory(fallbackDir);
+            return Path.Combine(fallbackDir, fileName);
+        }