fix build report null ref, if no project path found in editor.log

Author: unitycoder

UnityLauncherPro/GetProjects.cs

@@ -77,8 +77,7 @@ public static List<Project> Scan(bool getGitBranch = false, bool getPlasticBranc
             // scan info for custom folders (if not already on the list)
             if (AllProjectPaths != null)
             {
-                // custom full list (may contain duplicates)
-                //foreach (var p in projectsFound)
+                // iterate custom full project history
                 foreach (var projectPath in AllProjectPaths)
                 {
                     // check if registry list contains this path
@@ -92,7 +91,7 @@ public static List<Project> Scan(bool getGitBranch = false, bool getPlasticBranc
                         }
                     }
 
-                    // if not found from full history list, add
+                    // if not found from full history list, add to projects list
                     if (found == false)
                     {
                         var p = GetProjectInfo(projectPath, getGitBranch, getPlasticBranch, getArguments, showMissingFolders, showTargetPlatform);

UnityLauncherPro/MainWindow.xaml.cs

@@ -1981,9 +1981,18 @@ void RefreshBuildReports()
                                 singleReport.ElapsedTimeMS = long.Parse(ms);
                                 collectedBuildTime = true;
 
-                                // get streamingassets folder size and add to report, NOTE need to recalculate sizes then?
-                                long streamingAssetFolderSize = Tools.GetFolderSizeInBytes(Path.Combine(currentBuildReportProjectPath, "Assets", "StreamingAssets"));
-                                singleReport.Stats.Insert(singleReport.Stats.Count - 1, new BuildReportItem() { Category = "StreamingAssets", Size = Tools.GetBytesReadable(streamingAssetFolderSize) });
+                                if (string.IsNullOrEmpty(currentBuildReportProjectPath) == false)
+                                {
+                                    // get streamingassets folder size and add to report, NOTE need to recalculate sizes then?
+                                    string streamingAssetPath = Path.Combine(currentBuildReportProjectPath, "Assets", "StreamingAssets");
+                                    var streamingAssetFolderSize = Tools.GetFolderSizeInBytes(streamingAssetPath);
+                                    singleReport.Stats.Insert(singleReport.Stats.Count - 1, new BuildReportItem() { Category = "StreamingAssets", Size = Tools.GetBytesReadable(streamingAssetFolderSize) });
+                                }
+                                else
+                                {
+                                    // this can happen if editor log file was overwritten with another running editor? (so that start of the log file doesnt contain project path)
+                                    Console.WriteLine("Failed to get project path from build report..");
+                                }
 
                                 // add all rows and stat rows for this build report
                                 buildReports.Add(singleReport);
@@ -2062,7 +2071,7 @@ void RefreshBuildReports()
                     }
                 }
             }
-            catch (Exception)
+            catch (Exception e)
             {
                 gridBuildReport.ItemsSource = null;
                 gridBuildReport.Items.Clear();
@@ -2073,7 +2082,8 @@ void RefreshBuildReports()
                 txtBuildTime.Text = "";
 
                 Console.WriteLine("Failed to open editor log or other error in parsing: " + logFile);
-                SetStatus("Failed to open editor log or other error in parsing: " + logFile);
+                Console.WriteLine(e);
+                SetStatus("Failed to open editor log or other parsing error..");
                 return;
             }
 

UnityLauncherPro/Tools.cs

@@ -1704,6 +1704,7 @@ public static bool CreateDesktopShortCut(Project proj, string batchFolder)
 
         internal static long GetFolderSizeInBytes(string currentBuildReportProjectPath)
         {
+            // FIXME: 0 is not really correct for missing folder..
             if (Directory.Exists(currentBuildReportProjectPath) == false) return 0;
 
             return DirSize(new DirectoryInfo(currentBuildReportProjectPath));