Bug fixes, and improved test coverage

Author: ethantkoenig

gogs_client/updates.py

@@ -81,9 +81,11 @@ def set_admin(self, admin):
 
         def set_allow_git_hook(self, allow_git_hook):
             self._allow_git_hook = allow_git_hook
+            return self
 
         def set_allow_import_local(self, allow_import_local):
             self._allow_import_local = allow_import_local
+            return self
 
         def build(self):
             return GogsUserUpdate(

tests/interface_test.py

@@ -156,8 +156,12 @@ def test_get_user1(self):
         responses.add(responses.GET, uri2, status=404)
         user = self.client.get_user(None, "username1")
         self.assert_users_equals(user, self.expected_user)
-        self.assertRaises(gogs_client.GogsApi.ApiFailure, self.client.get_user,
-                          None, "username2")
+        try:
+            self.client.get_user(None, "username2")
+            raise AssertionError("Call to get_user did not raise an exception")
+        except gogs_client.GogsApi.ApiFailure as exc:
+            self.assertIsNotNone(exc.message)
+            self.assertEqual(exc.status_code, 404)
         self.assertEqual(len(responses.calls), 2)
         first_call = responses.calls[0]
         self.assertEqual(first_call.request.url, uri1)
@@ -170,6 +174,9 @@ def test_update_user1(self):
             .set_full_name("Example User")\
             .set_password("Password")\
             .set_website("mywebsite.net")\
+            .set_active(True)\
+            .set_admin(False)\
+            .set_allow_git_hook(False)\
             .build()
 
         def callback(request):
@@ -179,6 +186,12 @@ def callback(request):
             self.assertEqual(data["email"], "user@example.com")
             self.assertEqual(data["password"], "Password")
             self.assertEqual(data["website"], "mywebsite.net")
+            self.assertRegexpMatches(str(data["active"]), r"[tT]rue")
+            self.assertRegexpMatches(str(data["admin"]), r"[fF]alse")
+            self.assertRegexpMatches(str(data["allow_git_hook"]), r"[fF]alse")
+            self.assertNotIn("source_id", data)
+            self.assertNotIn("location", data)
+            self.assertNotIn("allow_import_local", data)
             return 200, {}, self.user_json_str
         uri = self.path("/admin/users/username")
         responses.add_callback(responses.PATCH, uri, callback=callback)