Skip to content

Commit 5df621e

Browse files
authored
Merge pull request #30 from aivis/add-server-ip-field
add server_ip field
2 parents 180df22 + fc87df7 commit 5df621e

File tree

5 files changed

+15
-2
lines changed

5 files changed

+15
-2
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ php:
44
- 7.0
55
- 7.1
66
- 7.2
7-
- hhvm
7+
- 7.3
88

99
before_script:
1010
- travis_retry composer self-update

src/Understand/UnderstandLaravel5/EventLogger.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ protected function getMetaFields()
7878
'url' => 'UnderstandFieldProvider::getUrl',
7979
'method' => 'UnderstandFieldProvider::getRequestMethod',
8080
'client_ip' => 'UnderstandFieldProvider::getClientIp',
81+
'server_ip' => 'UnderstandFieldProvider::getServerIp',
8182
];
8283
}
8384
}

src/Understand/UnderstandLaravel5/ExceptionLogger.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ protected function getMetaFields()
135135
'url' => 'UnderstandFieldProvider::getUrl',
136136
'method' => 'UnderstandFieldProvider::getRequestMethod',
137137
'client_ip' => 'UnderstandFieldProvider::getClientIp',
138+
'server_ip' => 'UnderstandFieldProvider::getServerIp',
138139
'user_agent' => 'UnderstandFieldProvider::getClientUserAgent',
139140
'laravel_version' => 'UnderstandFieldProvider::getLaravelVersion',
140141
'sql_queries' => 'UnderstandFieldProvider::getSqlQueries',

tests/ExceptionEncoderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ protected function assertIncompleteClassStackTrace($exception, $index)
100100
$encoder = new Understand\UnderstandLaravel5\ExceptionEncoder();
101101
$stackTraceArray = $encoder->stackTraceToArray($exception->getTrace());
102102

103-
if (starts_with(phpversion(), '7.2'))
103+
if (starts_with(phpversion(), ['7.2', '7.3']))
104104
{
105105
$this->assertSame('__PHP_Incomplete_Class', $stackTraceArray[$index]['args'][0]);
106106
}

tests/FieldProviderTest.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,15 @@ public function testQueryCount()
9191

9292
$this->assertCount(100, $queries);
9393
}
94+
95+
public function testGetServerIp()
96+
{
97+
$this->app['understand.dataCollector']->set('sql_queries', range(1, 1000));
98+
99+
$this->call('GET', '/', [], [], [], ['SERVER_ADDR' => '127.0 0.1']);
100+
101+
$ip = $this->app['understand.fieldProvider']->getServerIp();
102+
103+
$this->assertEquals('127.0 0.1', $ip);
104+
}
94105
}

0 commit comments

Comments
 (0)