fix(reactant-module): fix subscribe issue

Author: unadlib

packages/reactant-module/src/core/createStore.ts

@@ -82,7 +82,7 @@ export function createStore<T = any>({
   let isExistReducer = false;
   let store: ReactantStore | undefined = originalStore;
   let reducers: ReducersMapObject = {};
-  const subscriptions: Subscriptions = [];
+  const subscriptions: Subscriptions[] = [];
   // TODO: replace with `mutative`
   const enableAutoFreeze = devOptions.autoFreeze ?? true;
   const enableReduxDevTools = devOptions.reduxDevTools ?? __DEV__;
@@ -252,7 +252,7 @@ export function createStore<T = any>({
           }
         }
         if (Array.isArray(service[subscriptionsKey])) {
-          subscriptions.push(...service[subscriptionsKey]!);
+          subscriptions.push(service[subscriptionsKey]!);
         }
         Object.defineProperties(service, {
           [modulesKey]: {
@@ -360,6 +360,6 @@ export function createStore<T = any>({
     // TODO: refactor hook
     beforeReplaceReducer();
   }
-  perform(subscriptions);
+  perform(Array.prototype.concat.apply([], subscriptions));
   return store;
 }

packages/reactant-module/test/core/subscriber.test.ts

@@ -111,10 +111,22 @@ test('subscribe in constructor', () => {
 test('subscribe in non-constructor', () => {
   const storeSubscribeFn = jest.fn();
   const subscribeFn = jest.fn();
+  const subscribeFn0 = jest.fn();
   const whenFn = jest.fn();
 
+  @injectable()
+  class Foo0 {
+    useSubscribe() {
+      subscribe(this, subscribeFn0);
+    }
+  }
+
   @injectable()
   class Foo {
+    constructor(private foo0: Foo0) {
+      this.foo0.useSubscribe();
+    }
+
     unsubscribe?: () => void;
 
     dispose?: () => void;
@@ -175,31 +187,37 @@ test('subscribe in non-constructor', () => {
   foo.increase();
   expect(storeSubscribeFn.mock.calls.length).toBe(1);
   expect(subscribeFn.mock.calls.length).toBe(1);
+  expect(subscribeFn0.mock.calls.length).toBe(1);
   expect(subscribeFn.mock.calls).toEqual([[]]);
+  expect(subscribeFn0.mock.calls).toEqual([[]]);
   expect(whenFn.mock.calls).toEqual([[2, 1]]);
   foo.increase();
   expect(storeSubscribeFn.mock.calls.length).toBe(2);
   expect(subscribeFn.mock.calls.length).toBe(2);
+  expect(subscribeFn0.mock.calls.length).toBe(2);
   expect(whenFn.mock.calls).toEqual([
     [2, 1],
     [3, 2],
   ]);
   foo.increase1();
   expect(storeSubscribeFn.mock.calls.length).toBe(3);
   expect(subscribeFn.mock.calls.length).toBe(3);
+  expect(subscribeFn0.mock.calls.length).toBe(3);
   expect(whenFn.mock.calls).toEqual([
     [2, 1],
     [3, 2],
   ]);
   foo.increase1();
   expect(storeSubscribeFn.mock.calls.length).toBe(4);
   expect(subscribeFn.mock.calls.length).toBe(4);
+  expect(subscribeFn0.mock.calls.length).toBe(4);
   expect(whenFn.mock.calls.length).toEqual(2);
 
   foo.unsubscribe!();
   foo.increase();
   expect(storeSubscribeFn.mock.calls.length).toBe(5);
   expect(subscribeFn.mock.calls.length).toBe(4);
+  expect(subscribeFn0.mock.calls.length).toBe(5);
   expect(whenFn.mock.calls.length).toEqual(3);
 
   foo.dispose!();