Skip to content

Commit 78ab779

Browse files
committed
Update AWS credentials configuration in workflows
1 parent e632369 commit 78ab779

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

.github/workflows/auto-update.yml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,17 @@ concurrency:
1313
jobs:
1414
auto-update:
1515
runs-on: ubuntu-latest
16-
16+
env:
17+
AWS_REGION: ap-northeast-1
1718
steps:
1819
- name: Checkout
1920
uses: actions/checkout@v3
2021
with:
2122
fetch-depth: 0
23+
- uses: aws-actions/configure-aws-credentials@v4
24+
with:
25+
aws-region: ${{ env.AWS_REGION }}
26+
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
2227
- name: Install serverless
2328
run: npm install -g serverless
2429
- name: Note docker image digest
@@ -50,10 +55,6 @@ jobs:
5055
sed -r "s/public.ecr.aws\/lambda\/python[:@a-z0-9]+/public.ecr.aws\/lambda\/python\@sha256\:${SHA256_DIGEST}/g; s/chrome-for-testing-public\/[0-9.]+/chrome-for-testing-public\/${CHROME_VERSION}/g; s/selenium==[0-9\.]*/selenium==${SELENIUM_VERSION}/g" -i Dockerfile
5156
- name: Deploy
5257
run: sls deploy
53-
env:
54-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
55-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
56-
AWS_REGION: ${{ secrets.AWS_REGION }}
5758
- name: Note chrome version
5859
id: chrome-version
5960
run: |
@@ -67,10 +68,6 @@ jobs:
6768
- name: Invoke
6869
id: invoke
6970
run: sls invoke -f demo > /tmp/scraping-result.txt
70-
env:
71-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
72-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
73-
AWS_REGION: ${{ secrets.AWS_REGION }}
7471
- name: Archive result
7572
uses: actions/upload-artifact@v3
7673
if: ${{ !env.ACT }}

.github/workflows/demo-test.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,17 @@ concurrency:
1414
jobs:
1515
demo-test:
1616
runs-on: ubuntu-latest
17-
17+
env:
18+
AWS_REGION: ap-northeast-1
1819
steps:
20+
- uses: aws-actions/configure-aws-credentials@v4
21+
with:
22+
aws-region: ${{ env.AWS_REGION }}
23+
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
1924
- name: Demo README's instructions
2025
run: |
2126
npm install -g serverless
2227
sls create --template-url "https://github.com/umihico/docker-selenium-lambda/tree/main" --path docker-selenium-lambda && cd $_
2328
sls deploy
2429
sls invoke --function demo |& tee /tmp/scraping-result.txt
2530
cat /tmp/scraping-result.txt | grep -q "This domain is for use in illustrative examples in documents"
26-
env:
27-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
28-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
29-
AWS_REGION: ${{ secrets.AWS_REGION }}

0 commit comments

Comments
 (0)