Merge branch 'develop-umbraco-version-8' into master-umbraco-version-8

Author: Jeavon

appveyor.yml

@@ -9,7 +9,7 @@ configuration: Release
 
 environment:
   # Version Suffix
-  version_suffix: alpha4
+  version_suffix: alpha5
 
 install:
   - ps: .\build\appveyor-semver.ps1

src/UmbracoFileSystemProviders.Azure/AzureBlobFileSystem.cs

@@ -159,7 +159,11 @@ public AzureBlobFileSystem(string alias)
         /// </summary>
         public AzureFileSystem FileSystem { get; }
 
-        public bool CanAddPhysical => throw new NotImplementedException();
+        /// <summary>
+        /// Indicates whether the filesystem can add/copy a file that is on local disk, in a fast and efficient way.
+        /// We can't so always returns false.
+        /// </summary>
+        public bool CanAddPhysical => false;
 
         /// <summary>
         /// Adds a file to the file system.

src/UmbracoFileSystemProviders.Azure/AzureFileSystem.cs

@@ -211,7 +211,7 @@ internal AzureFileSystem(string containerName, string rootUrl, string connection
         /// </summary>
         public string ApplicationVirtualPath { get; internal set; } = HttpRuntime.AppDomainAppVirtualPath;
 
-        public bool CanAddPhysical => throw new NotImplementedException();
+        public bool CanAddPhysical => false;
 
         /// <summary>
         /// Returns a singleton instance of the <see cref="AzureFileSystem"/> class.
@@ -344,7 +344,9 @@ public void AddFile(string path, Stream stream)
         /// <inheritdoc/>
         public void AddFile(string path, string physicalPath, bool overrideIfExists = true, bool copy = false)
         {
-            //Valid as the property 'CanAddPhysical' is not implemented either
+            var fullPath = GetFullPath(path);
+            Current.Logger.Debug<AzureBlobFileSystem>($"NotImplemented! AddFile(path, physicalPath, overrideIfExists, copy) method executed with path:{path}, {physicalPath}, {overrideIfExists}, {copy} - fullPath: {fullPath}");
+
             throw new NotImplementedException();
         }
 
@@ -543,23 +545,23 @@ public IEnumerable<string> GetFiles(string path, string filter)
             }
 
             return blobList.OfType<CloudBlockBlob>().Select(cd =>
-                {
-                    string url = cd.Uri.AbsoluteUri;
+            {
+                string url = cd.Uri.AbsoluteUri;
 
-                    if (filter.Equals("*.*", StringComparison.InvariantCultureIgnoreCase))
-                    {
-                        return url.Substring(this.rootContainerUrl.Length);
-                    }
+                if (filter.Equals("*.*", StringComparison.InvariantCultureIgnoreCase))
+                {
+                    return url.Substring(this.rootContainerUrl.Length);
+                }
 
-                    // Filter by name.
-                    filter = filter.TrimStart('*');
-                    if (url.IndexOf(filter, StringComparison.InvariantCultureIgnoreCase) > -1)
-                    {
-                        return url.Substring(this.rootContainerUrl.Length);
-                    }
+                // Filter by name.
+                filter = filter.TrimStart('*');
+                if (url.IndexOf(filter, StringComparison.InvariantCultureIgnoreCase) > -1)
+                {
+                    return url.Substring(this.rootContainerUrl.Length);
+                }
 
-                    return null;
-                }).Where(x => x != null);
+                return null;
+            }).Where(x => x != null);
         }
 
         /// <summary>
@@ -810,7 +812,7 @@ private CloudBlockBlob GetBlockBlobReference(string path)
                 // blob doesn't exist yet
                 var blobReference = this.cloudBlobContainer.GetBlockBlobReference(blobPath);
                 return blobReference;
-                
+
             }
             catch (StorageException ex)
             {