chore: cosmetic changes

Author: uetchy

package.json

@@ -10,7 +10,7 @@
     "prepublishOnly": "npm run clean && npm run build",
     "readme": "doctoc -p README.md",
     "release": "release-it",
-    "test": "npm run tsup && vitest --run",
+    "test": "npm run build && vitest --run",
     "toc": "doctoc README.md",
     "tsup": "tsup src/index.ts src/cli.ts -d lib"
   },

src/cli.ts

@@ -40,11 +40,13 @@ ${chalk.yellow(
 
 create('create-create-app', {
   templateRoot,
+  caveat,
   promptForTemplate: true,
+
   modifyName: (name) => (name.startsWith('create-') ? name : `create-${name}`),
+
   after: async ({ installNpmPackage }: AfterHookOptions) => {
     console.log('Installing the latest version of create-create-app');
     await installNpmPackage('create-create-app');
   },
-  caveat,
 });

src/index.ts

@@ -50,7 +50,7 @@ export interface AfterHookOptions {
     command: string,
     options?: CommonOptions<string>
   ) => ExecaChildProcess<string>;
-  installNpmPackage: (packageName: string) => Promise<void>;
+  installNpmPackage: (packageName: string, isDev?: boolean) => Promise<void>;
 }
 
 export enum NodePM {
@@ -89,40 +89,39 @@ async function getYargsOptions(
     interactive: { default: true },
     description: {
       type: 'input',
-      describe: 'description',
+      describe: 'Description',
       default: 'description',
       prompt: 'if-no-arg',
     },
     author: {
       type: 'input',
-      describe: 'author name',
+      describe: 'Author name',
       default: gitUser.name,
       prompt: 'if-no-arg',
     },
     email: {
       type: 'input',
-      describe: 'author email',
+      describe: 'Author email',
       default: gitUser.email,
       prompt: 'if-no-arg',
     },
     template: {
       type: 'list',
-      describe: 'template',
+      describe: 'Template',
       default: 'default',
       prompt: askForTemplate ? 'if-no-arg' : 'never',
       choices: availableTemplates,
     },
     license: {
       type: 'list',
-      describe: 'license',
+      describe: 'License',
       choices: [...availableLicenses(), 'UNLICENSED'],
       default: promptForLicense ? 'MIT' : 'UNLICENSED',
       prompt: promptForLicense ? 'if-no-arg' : 'never',
     },
     'node-pm': {
       type: 'list',
-      describe:
-        'select package manager to use for installing packages from npm',
+      describe: 'package manager to use for installing packages from npm',
       choices: ['npm', 'yarn', 'pnpm'],
       default: undefined, // undefined by default, we'll try to guess pm manager later
       prompt: promptForNodePM ? 'if-no-arg' : 'never',
@@ -225,10 +224,19 @@ export async function create(appName: string, options: Options) {
     // do not generate LICENSE
   }
 
+  const run = (command: string, options: CommonOptions<string> = {}) => {
+    const args = command.split(' ');
+    return execa(args[0], args.slice(1), {
+      stdio: 'inherit',
+      cwd: packageDir,
+      ...options,
+    });
+  };
+
   // init git
-  const skipGit = args['skip-git'];
 
   // init git if option skipGitInit or arg --skip-git are not set
+  const skipGit = args['skip-git'];
   if (!(options.skipGitInit || skipGit)) {
     try {
       console.log('\nInitializing a git repository');
@@ -239,17 +247,11 @@ export async function create(appName: string, options: Options) {
     }
   }
 
-  const run = (command: string, options: CommonOptions<string> = {}) => {
-    const args = command.split(' ');
-    return execa(args[0], args.slice(1), {
-      stdio: 'inherit',
-      cwd: packageDir,
-      ...options,
-    });
-  };
-
   // run Node.js related tasks (only if `package.json` does exist in the template root)
-  let installNpmPackage = async (packageName: string): Promise<void> => {};
+  let installNpmPackage = async (
+    pkg: string,
+    isDev?: boolean
+  ): Promise<void> => {};
 
   if (exists('package.json', packageDir)) {
     const nodePMArg = args['node-pm'];
@@ -267,16 +269,14 @@ export async function create(appName: string, options: Options) {
       pkg: string | string[],
       isDev: boolean = false
     ): Promise<void> => {
-      await addDeps({
-        rootDir: packageDir,
-        deps: Array.isArray(pkg) ? pkg : [pkg],
+      await addDeps(packageDir, Array.isArray(pkg) ? pkg : [pkg], {
         isDev,
         pm: packageManager,
       });
     };
   }
 
-  const afterHookOptions = {
+  const afterHookOptions: AfterHookOptions = {
     name,
     packageDir,
     template,

src/npm.ts

@@ -1,4 +1,4 @@
-import { NodePM, printCommand, CLIError } from '.';
+import { CLIError, NodePM, printCommand } from '.';
 import { spawnPromise } from './fs';
 
 function getPm(name: string) {
@@ -11,7 +11,7 @@ function getPm(name: string) {
 
     case 'npm':
       return NodePM.Npm;
-  
+
     default:
       return NodePM.Npm;
   }
@@ -23,17 +23,17 @@ function getPm(name: string) {
 // https://github.com/zkochan/packages/tree/main/which-pm-runs
 export function whichPm(defaultPm?: string) {
   // if there's a default pm (passed by argv), use it
-  if(defaultPm) {
+  if (defaultPm) {
     return getPm(defaultPm);
   }
 
   if (!process.env.npm_config_user_agent) {
     return NodePM.Npm;
   }
 
-  const pmSpec = process.env.npm_config_user_agent.split(' ')[0]
-  const separatorPos = pmSpec.lastIndexOf('/')
-  const name = pmSpec.substring(0, separatorPos)
+  const pmSpec = process.env.npm_config_user_agent.split(' ')[0];
+  const separatorPos = pmSpec.lastIndexOf('/');
+  const name = pmSpec.substring(0, separatorPos);
 
   return getPm(name);
 }
@@ -72,17 +72,17 @@ export async function installDeps(rootDir: string, pm: NodePM) {
   }
 }
 
-export async function addDeps({
-  rootDir,
-  deps,
-  isDev = false,
-  pm,
-}: {
-  rootDir: string;
-  deps: string[];
-  isDev?: boolean;
-  pm: NodePM;
-}) {
+export async function addDeps(
+  rootDir: string,
+  deps: string[],
+  {
+    isDev = false,
+    pm,
+  }: {
+    isDev?: boolean;
+    pm: NodePM;
+  }
+) {
   let command: string;
   let args: string[];