Rework splint output parsing to make sure return values are always true unless

splint ran and reported error.

Author: jonasbardino

.github/workflows/python-c-ext-sanity-check.yml

@@ -86,14 +86,13 @@ jobs:
           fetch-depth: 0  # This is necessary to get the commits
       - name: Lint with splint
         run: |
-          touch splint.log
           # NOTE: we only run splint error check for changed C files to limit noise
           # NOTE: point splint to Ubuntu's custom /usr/include/python3.x for Python.h
           echo "Lint changed code files: $(git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.c$')"
           # NOTE: show splint warnings but don't fail unless it found critical errors
           git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.c$' | xargs -r splint +posixlib -D__gnuc_va_list=va_list $(python3-config --includes) &> splint.log || true
-          cat splint.log
-          grep '*** Cannot continue' splint.log && false
+          [ ! -e splint.log ] || cat splint.log
+          [ ! -e splint.log ] || ! grep -q ' Cannot continue' splint.log
 
   lint-c-ext-python3-ubuntu-lts:
     # Mainly fallback when the above job doesn't work
@@ -113,15 +112,14 @@ jobs:
           fetch-depth: 0  # This is necessary to get the commits
       - name: Lint with splint
         run: |
-          touch splint.log
           # NOTE: we only run splint error check for changed C files to limit noise
           # NOTE: point splint to Ubuntu's custom /usr/include/python3.x for Python.h
           echo "Lint changed code files: $(git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.c$')"
           # NOTE: splint complains about NATIVE_TSS_KEY_T in system header here
           # NOTE: show splint warnings but don't fail unless it found critical errors
           git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.c$' | xargs -r splint +posixlib -D__gnuc_va_list=va_list -DNATIVE_TSS_KEY_T=char $(python3-config --includes) &> splint.log || true
-          cat splint.log
-          grep '*** Cannot continue' splint.log && false
+          [ ! -e splint.log ] || cat splint.log
+          [ ! -e splint.log ] || ! grep -q ' Cannot continue' splint.log
 
   lint-c-ext-python3-rocky9:
     name: Sanity check c-extension module code in default python3 on Rocky9
@@ -155,12 +153,11 @@ jobs:
         run: |
           # NOTE: perms are not right inside container so repeat what checkout module does.
           git config --global --add safe.directory "$PWD"
-          touch splint.log
           # NOTE: we only run splint error check for changed C files to limit noise
           echo "Lint changed code files: $(git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.c$')"
           echo "with splint from $(which splint)"
           ls -l /bin/splint
           # NOTE: show splint warnings but don't fail unless it found critical errors
           git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.c$' | xargs -r splint +posixlib -D__gnuc_va_list=va_list &> splint.log || true
-          cat splint.log
-          grep '*** Cannot continue' splint.log && false
+          [ ! -e splint.log ] || cat splint.log
+          [ ! -e splint.log ] || ! grep -q ' Cannot continue' splint.log