Another attempt at making splint happy.

Author: jonasbardino

.github/workflows/python-c-ext-sanity-check.yml

@@ -90,7 +90,7 @@ jobs:
           # NOTE: point splint to Ubuntu's custom /usr/include/python3.x for Python.h
           echo "Lint changed code files: $(git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$')"
           # NOTE: show splint warnings but don't fail unless it found critical errors
-          git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$' | xargs -r splint +posixlib +unixlib +gnuextensions -D__gnuc_va_list=va_list -DNATIVE_TSS_KEY_T=char $(python3-config --includes) -check &> splint.log || true
+          git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$' | xargs -r splint +posixlib +gnuextensions -D__gnuc_va_list=va_list $(python3-config --includes) &> splint.log || true
           cat splint.log
           grep '*** Cannot continue' splint.log && false
 
@@ -115,8 +115,9 @@ jobs:
           # NOTE: we only run splint error check for changed C files to limit noise
           # NOTE: point splint to Ubuntu's custom /usr/include/python3.x for Python.h
           echo "Lint changed code files: $(git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$')"
+          # NOTE: splint complains about NATIVE_TSS_KEY_T in system header here
           # NOTE: show splint warnings but don't fail unless it found critical errors
-          git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$' | xargs -r splint +posixlib +unixlib +gnuextensions -D__gnuc_va_list=va_list -DNATIVE_TSS_KEY_T=char $(python3-config --includes) -check &> splint.log || true
+          git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$' | xargs -r splint +posixlib +gnuextensions -D__gnuc_va_list=va_list -DNATIVE_TSS_KEY_T=char $(python3-config --includes) &> splint.log || true
           cat splint.log
           grep '*** Cannot continue' splint.log && false
 
@@ -157,6 +158,6 @@ jobs:
           echo "with splint from $(which splint)"
           ls -l /bin/splint
           # NOTE: show splint warnings but don't fail unless it found critical errors
-          git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$' | xargs -r splint +posixlib +unixlib +gnuextensions -D__gnuc_va_list=va_list -DNATIVE_TSS_KEY_T=char -check &> splint.log || true
+          git diff --diff-filter=ACMRTB --name-only HEAD^1 -- | grep -E '\.(c|h)$' | xargs -r splint +posixlib +gnuextensions -D__gnuc_va_list=va_list &> splint.log || true
           cat splint.log
           grep '*** Cannot continue' splint.log && false