set replica-announce-ip on pods so that operator works with istio service mesh

wihtout this the redis IP is identified as 127.0.0.1

Author: cameronbraid

pkg/client/redis/client.go

@@ -272,6 +272,10 @@ func (c *client) SetCustomRedisConfig(ip string, configs map[string]string, auth
 	rClient := rediscli.NewClient(options)
 	defer rClient.Close()
 
+	if err := c.applyRedisConfig("replica-announce-ip", ip, rClient); err != nil {
+		return err
+	}
+
 	for param, value := range configs {
 		//param, value, err := c.getConfigParameters(config)
 		//if err != nil {

pkg/controller/service/check.go

@@ -62,6 +62,10 @@ func (r *RedisClusterChecker) CheckRedisConfig(redisCluster *redisv1beta1.RedisC
 		return err
 	}
 
+	if _, ok := configs["replica-announce-ip"]; !ok {
+		return fmt.Errorf("configs conflict, expect: replica-announce-ip to be set")
+	}
+
 	// TODO when custom config use unit like mb gb, will return configs conflict
 	for key, value := range redisCluster.Spec.Config {
 		if value != configs[key] {

pkg/controller/service/heal.go

@@ -124,9 +124,9 @@ func (r *RedisClusterHealer) SetSentinelCustomConfig(ip string, rc *redisv1beta1
 
 // SetRedisCustomConfig will call redis to set the configuration given in config
 func (r *RedisClusterHealer) SetRedisCustomConfig(ip string, rc *redisv1beta1.RedisCluster, auth *util.AuthConfig) error {
-	if len(rc.Spec.Config) == 0 && len(auth.Password) == 0 {
-		return nil
-	}
+	// if len(rc.Spec.Config) == 0 && len(auth.Password) == 0 {
+	// 	return nil
+	// }
 
 	//if len(auth.Password) != 0 {
 	//	rc.Spec.Config["requirepass"] = auth.Password