Merge pull request #62 from pepakriz/scoped-container-fix

Scoped container creates new instance for first time only

Author: pleerock

src/ContainerInstance.ts

@@ -105,7 +105,9 @@ export class ContainerInstance {
         if (service && this !== globalContainer) {
             const clonedService = Object.assign({}, service);
             clonedService.value = undefined;
-            return this.getServiceValue(identifier, clonedService);
+            const value = this.getServiceValue(identifier, clonedService);
+            this.set(identifier, value);
+            return value;
         }
 
         return this.getServiceValue(identifier, service);
@@ -151,6 +153,11 @@ export class ContainerInstance {
      */
     set(token: Token<any>, value: any): this;
 
+    /**
+     * Sets a value for the given type or service name in the container.
+     */
+    set(token: ServiceIdentifier, value: any): this;
+
     /**
      * Sets a value for the given type or service name in the container.
      */

test/github-issues/61/issue-61.spec.ts

@@ -0,0 +1,37 @@
+import "reflect-metadata";
+import {Container} from "../../../src/Container";
+import {Service} from "../../../src/decorators/Service";
+
+describe("github issues > #61 Scoped container creates new instance of service every time", function() {
+
+    beforeEach(() => Container.reset());
+
+    it("should work properly", function() {
+
+        @Service()
+        class Car {
+            public serial = Math.random();
+        }
+
+        const fooContainer = Container.of("foo");
+        const barContainer = Container.of("bar");
+
+        const car1Serial = Container.get(Car).serial;
+        const car2Serial = Container.get(Car).serial;
+
+        const fooCar1Serial = fooContainer.get(Car).serial;
+        const fooCar2Serial = fooContainer.get(Car).serial;
+
+        const barCar1Serial = barContainer.get(Car).serial;
+        const barCar2Serial = barContainer.get(Car).serial;
+
+        car1Serial.should.be.equal(car2Serial);
+        fooCar1Serial.should.be.equal(fooCar2Serial);
+        barCar1Serial.should.be.equal(barCar2Serial);
+
+        car1Serial.should.not.be.equal(fooCar1Serial);
+        car1Serial.should.not.be.equal(barCar1Serial);
+        fooCar1Serial.should.not.be.equal(barCar1Serial);
+    });
+
+});