fix: Fix support of array whitelist query param

BenjD90 · BenjD90 · commit 8e211f335ba3 · 2021-03-29T16:59:17.000+02:00
diff --git a/src/ActionParameterHandler.ts b/src/ActionParameterHandler.ts
@@ -132,6 +132,8 @@ export class ActionParameterHandler<T extends BaseDriver> {
         case 'date':
           const normalizedValue = this.normalizeStringValue(value, param.name, param.targetName);
           return param.isArray ? [normalizedValue] : normalizedValue;
+        case 'array':
+          return [value];
       }
     } else if (Array.isArray(value)) {
       return value.map(v => this.normalizeStringValue(v, param.name, param.targetName));
diff --git a/test/functional/action-params.spec.ts b/test/functional/action-params.spec.ts
@@ -139,6 +139,13 @@ describe(``, () => {
       multipleDateValues?: Date[];
     }
 
+    class QueryWhitelistClass {
+      @IsArray()
+      @IsBoolean({ each: true })
+      @Transform(value => (Array.isArray(value) ? value.map(v => v !== 'false') : value !== 'false'))
+      multipleBooleanValues?: boolean[];
+    }
+
     @Controller()
     class UserActionParamsController {
       @Get('/users')
@@ -239,6 +246,14 @@ describe(``, () => {
         return `<html><body>hello</body></html>`;
       }
 
+      @Get('/photos-params-whitelist')
+      getPhotosWithWhitelistQuery(
+        @QueryParams({ validate: { whitelist: true, forbidNonWhitelisted: true } }) query: QueryWhitelistClass
+      ): string {
+        queryParams3 = query;
+        return `<html><body>hello</body></html>`;
+      }
+
       @Get('/photos-with-required')
       getPhotosWithIdRequired(@QueryParam('limit', { required: true }) limit: number): string {
         queryParamLimit = limit;
@@ -594,6 +609,14 @@ describe(``, () => {
     expect(queryParams1.multipleDateValues).toEqual([new Date('2017-02-01T01:00:00Z')]);
   });
 
+  it("@QueryParams should give a proper values from request's query with validate whitelist option on", async () => {
+    expect.assertions(3);
+    const response = await axios.get('/photos-params-whitelist?multipleBooleanValues=false');
+    expect(response.status).toEqual(HttpStatusCodes.OK);
+    expect(response.headers['content-type']).toEqual('text/html; charset=utf-8');
+    expect(queryParams3.multipleBooleanValues).toEqual([false]);
+  });
+
   it("@QueryParams should give a proper values from request's query parameters with nested json", async () => {
     expect.assertions(13);
     const response = await axios.get(

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,8 @@ export class ActionParameterHandler<T extends BaseDriver> {`
`132`	`132`	`case 'date':`
`133`	`133`	`const normalizedValue = this.normalizeStringValue(value, param.name, param.targetName);`
`134`	`134`	`return param.isArray ? [normalizedValue] : normalizedValue;`
	`135`	`+ case 'array':`
	`136`	`+ return [value];`
`135`	`137`	`}`
`136`	`138`	`} else if (Array.isArray(value)) {`
`137`	`139`	`return value.map(v => this.normalizeStringValue(v, param.name, param.targetName));`