Fix validating param object when type is any or an interface (reflected as Object)

MichalLytek · MichalLytek · commit 5c7faced2f85 · 2017-09-04T13:02:41.000+02:00
diff --git a/src/ActionParameterHandler.ts b/src/ActionParameterHandler.ts
@@ -177,7 +177,13 @@ export class ActionParameterHandler {
      * Perform class-validation if enabled.
      */
     protected validateValue(value: any, paramMetadata: ParamMetadata): Promise<any>|any {
-        if (paramMetadata.validate || (this.driver.enableValidation && paramMetadata.validate !== false)) {
+        const isValidationEnabled = (paramMetadata.validate instanceof Object || paramMetadata.validate === true)
+            || (this.driver.enableValidation === true && paramMetadata.validate !== false);
+        const shouldValidate = paramMetadata.targetType
+            && (paramMetadata.targetType !== Object)
+            && (value instanceof paramMetadata.targetType);
+
+        if (isValidationEnabled && shouldValidate) {
             const options = paramMetadata.validate instanceof Object ? paramMetadata.validate : this.driver.validationOptions;
             return validate(value, options)
                 .then(() => value)
diff --git a/test/functional/action-params.spec.ts b/test/functional/action-params.spec.ts
@@ -687,7 +687,7 @@ describe("action parameters", () => {
         };
 
         assertRequest([3001, 3002], "post", "files", undefined, requestOptions, response => {
-            // expect(uploadedFileName).to.be.eql("hello-world.txt");
+            expect(uploadedFileName).to.be.eql("hello-world.txt");
             expect(response).to.be.status(200);
             expect(response).to.have.header("content-type", "text/html; charset=utf-8");
             expect(response.body).to.be.equal("<html><body>hello-world.txt</body></html>");
