Added no-with-statement converter (#1070)

Author: Josh Goldberg

src/converters/lintConfigs/rules/ruleConverters.ts

@@ -109,6 +109,7 @@ import { convertNoUseBeforeDeclare } from "./ruleConverters/no-use-before-declar
 import { convertNoVarKeyword } from "./ruleConverters/no-var-keyword";
 import { convertNoVarRequires } from "./ruleConverters/no-var-requires";
 import { convertNoVoidExpression } from "./ruleConverters/no-void-expression";
+import { convertNoWithStatement } from "./ruleConverters/no-with-statement";
 import { convertObjectLiteralKeyQuotes } from "./ruleConverters/object-literal-key-quotes";
 import { convertObjectLiteralShorthand } from "./ruleConverters/object-literal-shorthand";
 import { convertOneLine } from "./ruleConverters/one-line";
@@ -376,6 +377,7 @@ export const ruleConverters = new Map([
     ["no-var-keyword", convertNoVarKeyword],
     ["no-var-requires", convertNoVarRequires],
     ["no-void-expression", convertNoVoidExpression],
+    ["no-with-statement", convertNoWithStatement],
     ["object-literal-key-quotes", convertObjectLiteralKeyQuotes],
     ["object-literal-shorthand", convertObjectLiteralShorthand],
     ["one-line", convertOneLine],
@@ -471,5 +473,4 @@ export const ruleConverters = new Map([
     // ["max-func-body-length", convertMaxFuncBodyLength],
     // ["no-function-expression", convertNoFunctionExpression], // ban-syntax config
     // ["no-suspicious-comment", convertNoSuspiciousComment],
-    // ["no-with-statement", convertNoWithStatement],
 ]);

src/converters/lintConfigs/rules/ruleConverters/no-with-statement.ts

@@ -0,0 +1,11 @@
+import { RuleConverter } from "../ruleConverter";
+
+export const convertNoWithStatement: RuleConverter = () => {
+    return {
+        rules: [
+            {
+                ruleName: "no-with",
+            },
+        ],
+    };
+};

src/converters/lintConfigs/rules/ruleConverters/tests/no-with-statement.test.ts

@@ -0,0 +1,17 @@
+import { convertNoWithStatement } from "../no-with-statement";
+
+describe(convertNoWithStatement, () => {
+    test("conversion without arguments", () => {
+        const result = convertNoWithStatement({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-with",
+                },
+            ],
+        });
+    });
+});