Fixed member-access converter for option length 1 (#336)

Author: Josh Goldberg

src/rules/converters/member-access.ts

@@ -22,7 +22,7 @@ export const convertMemberAccess: RuleConverter = tslintRule => {
         accessibility: AccessibilityLevel.Explicit,
     };
 
-    if (tslintRule.ruleArguments.length >= 2 || tslintRule.ruleArguments[0] === true) {
+    if (tslintRule.ruleArguments.length >= 1 || tslintRule.ruleArguments[0] === true) {
         for (const ruleArg of tslintRule.ruleArguments) {
             if (typeof ruleArg === "string") {
                 switch (ruleArg) {

src/rules/converters/tests/member-access.test.ts

@@ -32,6 +32,21 @@ describe(convertMemberAccess, () => {
     });
 
     test("conversion with no-public argument", () => {
+        const result = convertMemberAccess({
+            ruleArguments: ["no-public"],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleArguments: [{ accessibility: AccessibilityLevel.NoPublic }],
+                    ruleName: "@typescript-eslint/explicit-member-accessibility",
+                },
+            ],
+        });
+    });
+
+    test("conversion with true and no-public argument", () => {
         const result = convertMemberAccess({
             ruleArguments: [true, "no-public"],
         });
@@ -46,7 +61,7 @@ describe(convertMemberAccess, () => {
         });
     });
 
-    test("conversion with check-accessor argument", () => {
+    test("conversion with true and check-accessor argument", () => {
         const result = convertMemberAccess({
             ruleArguments: [true, "check-accessor"],
         });
@@ -68,7 +83,7 @@ describe(convertMemberAccess, () => {
         });
     });
 
-    test("conversion with check-constructor argument", () => {
+    test("conversion with true and check-constructor argument", () => {
         const result = convertMemberAccess({
             ruleArguments: [true, "check-constructor"],
         });
@@ -90,7 +105,7 @@ describe(convertMemberAccess, () => {
         });
     });
 
-    test("conversion with check-parameter-property argument", () => {
+    test("conversion with true and check-parameter-property argument", () => {
         const result = convertMemberAccess({
             ruleArguments: [true, "check-parameter-property"],
         });