rxjs-no-subject-value (#801)

* Adding the rule, mapping it and writing the tests

* Missing imports post merge

Co-authored-by: Krzysztof Brilla <brilla.krzysztof@gmail.com>
Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

Author: 3 people

src/converters/lintConfigs/rules/ruleConverters.ts

@@ -193,11 +193,11 @@ import { convertNoInternal } from "./ruleConverters/eslint-plugin-rxjs/no-intern
 import { convertNoNestedSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-nested-subscribe";
 import { convertNoRedundantNotify } from "./ruleConverters/eslint-plugin-rxjs/no-redundant-notify";
 import { convertNoShareReplay } from "./ruleConverters/eslint-plugin-rxjs/no-sharereplay";
+import { convertNoSubjectValue } from "./ruleConverters/eslint-plugin-rxjs/no-subject-value";
 import { convertNoUnboundMethods } from "./ruleConverters/eslint-plugin-rxjs/no-unbound-methods";
 import { convertNoUnsafeSubjectNext } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-subject-next";
 
 /**
- * Keys TSLint rule names to their ESLint rule converters.
  */
 export const ruleConverters = new Map([
     ["adjacent-overload-signatures", convertAdjacentOverloadSignatures],
@@ -390,6 +390,7 @@ export const ruleConverters = new Map([
     ["rxjs-no-nested-subscribe", convertNoNestedSubscribe],
     ["rxjs-no-redundant-notify", convertNoRedundantNotify],
     ["rxjs-no-sharereplay", convertNoShareReplay],
+    ["rxjs-no-subject-value", convertNoSubjectValue],
     ["rxjs-no-unbound-methods", convertNoUnboundMethods],
     ["rxjs-no-unsafe-subject-next", convertNoUnsafeSubjectNext],
 

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-subject-value.ts

@@ -0,0 +1,12 @@
+import { RuleConverter } from "../../ruleConverter";
+
+export const convertNoSubjectValue: RuleConverter = () => {
+    return {
+        rules: [
+            {
+                ruleName: "rxjs/no-subject-value",
+            },
+        ],
+        plugins: ["eslint-plugin-rxjs"],
+    };
+};

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-subject-value.test.ts

@@ -0,0 +1,18 @@
+import { convertNoSubjectValue } from "../no-subject-value";
+
+describe(convertNoSubjectValue, () => {
+    test("conversion without arguments", () => {
+        const result = convertNoSubjectValue({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "rxjs/no-subject-value",
+                },
+            ],
+            plugins: ["eslint-plugin-rxjs"],
+        });
+    });
+});