Fix ruleArguments (#281)

bouzuya · Josh Goldberg · commit 358612c0f1f4 · 2019-12-14T23:32:20.000-05:00
* fix convertSemicolon ruleArguments

* fix convertNewlineBeforeReturn ruleArguments
diff --git a/src/rules/converters/newline-before-return.ts b/src/rules/converters/newline-before-return.ts
@@ -6,7 +6,6 @@ export const convertNewlineBeforeReturn: RuleConverter = () => {
             {
                 ruleName: "padding-line-between-statements",
                 ruleArguments: [
-                    "error",
                     {
                         blankLine: "always",
                         prev: "*",
diff --git a/src/rules/converters/semicolon.ts b/src/rules/converters/semicolon.ts
@@ -24,7 +24,6 @@ export const convertSemicolon: RuleConverter = tslintRule => {
                 : [
                       {
                           ruleArguments: [
-                              "error",
                               {
                                   multiline: {
                                       delimiter: getMultilineDelimiter(tslintRule.ruleArguments[0]),
diff --git a/src/rules/converters/tests/newline-before-return.test.ts b/src/rules/converters/tests/newline-before-return.test.ts
@@ -11,7 +11,6 @@ describe(convertNewlineBeforeReturn, () => {
                 {
                     ruleName: "padding-line-between-statements",
                     ruleArguments: [
-                        "error",
                         {
                             blankLine: "always",
                             next: "return",
diff --git a/src/rules/converters/tests/semicolon.test.ts b/src/rules/converters/tests/semicolon.test.ts
@@ -14,7 +14,6 @@ describe(convertSemicolon, () => {
                 },
                 {
                     ruleArguments: [
-                        "error",
                         {
                             multiline: {
                                 delimiter: "semi",
@@ -45,7 +44,6 @@ describe(convertSemicolon, () => {
                 },
                 {
                     ruleArguments: [
-                        "error",
                         {
                             multiline: {
                                 delimiter: "none",
@@ -77,7 +75,6 @@ describe(convertSemicolon, () => {
                 {
                     ruleName: "@typescript-eslint/member-delimiter-style",
                     ruleArguments: [
-                        "error",
                         {
                             multiline: {
                                 delimiter: "semi",
@@ -111,7 +108,6 @@ describe(convertSemicolon, () => {
                 {
                     ruleName: "@typescript-eslint/member-delimiter-style",
                     ruleArguments: [
-                        "error",
                         {
                             multiline: {
                                 delimiter: "none",

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ export const convertNewlineBeforeReturn: RuleConverter = () => {`
`6`	`6`	`{`
`7`	`7`	`ruleName: "padding-line-between-statements",`
`8`	`8`	`ruleArguments: [`
`9`		`- "error",`
`10`	`9`	`{`
`11`	`10`	`blankLine: "always",`
`12`	`11`	`prev: "*",`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ export const convertSemicolon: RuleConverter = tslintRule => {`
`24`	`24`	`: [`
`25`	`25`	`{`
`26`	`26`	`ruleArguments: [`
`27`		`- "error",`
`28`	`27`	`{`
`29`	`28`	`multiline: {`
`30`	`29`	`delimiter: getMultilineDelimiter(tslintRule.ruleArguments[0]),`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ describe(convertNewlineBeforeReturn, () => {`
`11`	`11`	`{`
`12`	`12`	`ruleName: "padding-line-between-statements",`
`13`	`13`	`ruleArguments: [`
`14`		`- "error",`
`15`	`14`	`{`
`16`	`15`	`blankLine: "always",`
`17`	`16`	`next: "return",`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ describe(convertSemicolon, () => {`
`14`	`14`	`},`
`15`	`15`	`{`
`16`	`16`	`ruleArguments: [`
`17`		`- "error",`
`18`	`17`	`{`
`19`	`18`	`multiline: {`
`20`	`19`	`delimiter: "semi",`
`@@ -45,7 +44,6 @@ describe(convertSemicolon, () => {`
`45`	`44`	`},`
`46`	`45`	`{`
`47`	`46`	`ruleArguments: [`
`48`		`- "error",`
`49`	`47`	`{`
`50`	`48`	`multiline: {`
`51`	`49`	`delimiter: "none",`
`@@ -77,7 +75,6 @@ describe(convertSemicolon, () => {`
`77`	`75`	`{`
`78`	`76`	`ruleName: "@typescript-eslint/member-delimiter-style",`
`79`	`77`	`ruleArguments: [`
`80`		`- "error",`
`81`	`78`	`{`
`82`	`79`	`multiline: {`
`83`	`80`	`delimiter: "semi",`
`@@ -111,7 +108,6 @@ describe(convertSemicolon, () => {`
`111`	`108`	`{`
`112`	`109`	`ruleName: "@typescript-eslint/member-delimiter-style",`
`113`	`110`	`ruleArguments: [`
`114`		`- "error",`
`115`	`111`	`{`
`116`	`112`	`multiline: {`
`117`	`113`	`delimiter: "none",`