add no-duplicate-variable converter and unit test (#214)

* add no-duplicate-variable converter and unit test

* add dash in check parameters

Co-Authored-By: Josh Goldberg <joshuakgoldberg@outlook.com>

* Update no-duplicate-variable.test.ts

Author: deerawan

src/rules/converters.ts

@@ -45,6 +45,7 @@ import { convertNoDefaultExport } from "./converters/no-default-export";
 import { convertNoDuplicateImports } from "./converters/no-duplicate-imports";
 import { convertNoDuplicateSuper } from "./converters/no-duplicate-super";
 import { convertNoDuplicateSwitchCase } from "./converters/no-duplicate-switch-case";
+import { convertNoDuplicateVariable } from "./converters/no-duplicate-variable";
 import { convertNoEmpty } from "./converters/no-empty";
 import { convertNoEmptyInterface } from "./converters/no-empty-interface";
 import { convertNoEval } from "./converters/no-eval";
@@ -172,6 +173,7 @@ export const converters = new Map([
     ["no-duplicate-imports", convertNoDuplicateImports],
     ["no-duplicate-super", convertNoDuplicateSuper],
     ["no-duplicate-switch-case", convertNoDuplicateSwitchCase],
+    ["no-duplicate-variable", convertNoDuplicateVariable],
     ["no-empty-interface", convertNoEmptyInterface],
     ["no-empty", convertNoEmpty],
     ["no-eval", convertNoEval],

src/rules/converters/no-duplicate-variable.ts

@@ -0,0 +1,14 @@
+import { RuleConverter } from "../converter";
+
+export const convertNoDuplicateVariable: RuleConverter = tslintRule => {
+    return {
+        rules: [
+            {
+                ...(tslintRule.ruleArguments.includes("check-parameters") && {
+                    notices: ["ESLint does not support check-parameters."],
+                }),
+                ruleName: "no-redeclare",
+            },
+        ],
+    };
+};

src/rules/converters/tests/no-duplicate-variable.test.ts

@@ -0,0 +1,32 @@
+import { convertNoDuplicateVariable } from "../no-duplicate-variable";
+
+describe(convertNoDuplicateVariable, () => {
+    test("conversion without arguments", () => {
+        const result = convertNoDuplicateVariable({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-redeclare",
+                },
+            ],
+        });
+    });
+
+    test("conversion with check parameters argument", () => {
+        const result = convertNoDuplicateVariable({
+            ruleArguments: ["check-parameters"],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-redeclare",
+                    notices: ["ESLint does not support check-parameters."],
+                },
+            ],
+        });
+    });
+});