Skip to content

Commit e742625

Browse files
amcaseyamcasey
authored
Revert "Fix contextual discrimination for omitted members (microsoft#43937)" (microsoft#48426)
This reverts commit 751c114, which caused check time for our MUI benchmark to increase by ~25%.
1 parent 0cc3535 commit e742625

9 files changed

+67
-237
lines changed

‎src/compiler/checker.ts‎

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -26849,13 +26849,6 @@ namespace ts {
2684926849
return false;
2685026850
}
2685126851

26852-
function uniqueStrings(strings: readonly __String[]): __String[] {
26853-
const unique = new Set(strings);
26854-
const result: __String[] = [];
26855-
unique.forEach(str => result.push(str));
26856-
return result;
26857-
}
26858-
2685926852
function discriminateContextualTypeByObjectMembers(node: ObjectLiteralExpression, contextualType: UnionType) {
2686026853
return getMatchingUnionConstituentForObjectLiteral(contextualType, node) || discriminateTypeByDiscriminableItems(contextualType,
2686126854
concatenate(
@@ -26864,13 +26857,8 @@ namespace ts {
2686426857
prop => ([() => getContextFreeTypeOfExpression((prop as PropertyAssignment).initializer), prop.symbol.escapedName] as [() => Type, __String])
2686526858
),
2686626859
map(
26867-
uniqueStrings(flatMap(contextualType.types, memberType =>
26868-
map(
26869-
filter(getPropertiesOfType(memberType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26870-
s => s.escapedName
26871-
)
26872-
)),
26873-
name => [() => undefinedType, name] as [() => Type, __String]
26860+
filter(getPropertiesOfType(contextualType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26861+
s => [() => undefinedType, s.escapedName] as [() => Type, __String]
2687426862
)
2687526863
),
2687626864
isTypeAssignableTo,
@@ -26886,13 +26874,8 @@ namespace ts {
2688626874
prop => ([!(prop as JsxAttribute).initializer ? (() => trueType) : (() => getContextFreeTypeOfExpression((prop as JsxAttribute).initializer!)), prop.symbol.escapedName] as [() => Type, __String])
2688726875
),
2688826876
map(
26889-
uniqueStrings(flatMap(contextualType.types, memberType =>
26890-
map(
26891-
filter(getPropertiesOfType(memberType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26892-
s => s.escapedName
26893-
)
26894-
)),
26895-
name => [() => undefinedType, name] as [() => Type, __String]
26877+
filter(getPropertiesOfType(contextualType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26878+
s => [() => undefinedType, s.escapedName] as [() => Type, __String]
2689626879
)
2689726880
),
2689826881
isTypeAssignableTo,

‎tests/baselines/reference/discriminantPropertyInference.js‎

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ type DiscriminatorFalse = {
1111
cb: (x: number) => void;
1212
}
1313

14-
type Unrelated = {
15-
val: number;
16-
}
14+
type Props = DiscriminatorTrue | DiscriminatorFalse;
1715

1816
declare function f(options: DiscriminatorTrue | DiscriminatorFalse): any;
1917

@@ -39,14 +37,6 @@ f({
3937
f({
4038
cb: n => n.toFixed()
4139
});
42-
43-
44-
declare function g(options: DiscriminatorTrue | DiscriminatorFalse | Unrelated): any;
45-
46-
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
47-
g({
48-
cb: n => n.toFixed()
49-
});
5040

5141

5242
//// [discriminantPropertyInference.js]
@@ -70,7 +60,3 @@ f({
7060
f({
7161
cb: function (n) { return n.toFixed(); }
7262
});
73-
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
74-
g({
75-
cb: function (n) { return n.toFixed(); }
76-
});

‎tests/baselines/reference/discriminantPropertyInference.symbols‎

Lines changed: 25 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -23,97 +23,74 @@ type DiscriminatorFalse = {
2323
>x : Symbol(x, Decl(discriminantPropertyInference.ts, 9, 9))
2424
}
2525

26-
type Unrelated = {
27-
>Unrelated : Symbol(Unrelated, Decl(discriminantPropertyInference.ts, 10, 1))
28-
29-
val: number;
30-
>val : Symbol(val, Decl(discriminantPropertyInference.ts, 12, 18))
31-
}
26+
type Props = DiscriminatorTrue | DiscriminatorFalse;
27+
>Props : Symbol(Props, Decl(discriminantPropertyInference.ts, 10, 1))
28+
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(discriminantPropertyInference.ts, 0, 0))
29+
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(discriminantPropertyInference.ts, 5, 1))
3230

3331
declare function f(options: DiscriminatorTrue | DiscriminatorFalse): any;
34-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
35-
>options : Symbol(options, Decl(discriminantPropertyInference.ts, 16, 19))
32+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
33+
>options : Symbol(options, Decl(discriminantPropertyInference.ts, 14, 19))
3634
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(discriminantPropertyInference.ts, 0, 0))
3735
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(discriminantPropertyInference.ts, 5, 1))
3836

3937
// simple inference
4038
f({
41-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
39+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
4240

4341
disc: true,
44-
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 19, 3))
42+
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 17, 3))
4543

4644
cb: s => parseInt(s)
47-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 20, 15))
48-
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 21, 7))
45+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 18, 15))
46+
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 19, 7))
4947
>parseInt : Symbol(parseInt, Decl(lib.es5.d.ts, --, --))
50-
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 21, 7))
48+
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 19, 7))
5149

5250
});
5351

5452
// simple inference
5553
f({
56-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
54+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
5755

5856
disc: false,
59-
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 25, 3))
57+
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 23, 3))
6058

6159
cb: n => n.toFixed()
62-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 26, 16))
63-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 27, 7))
60+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 24, 16))
61+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 25, 7))
6462
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
65-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 27, 7))
63+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 25, 7))
6664
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
6765

6866
});
6967

7068
// simple inference when strict-null-checks are enabled
7169
f({
72-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
70+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
7371

7472
disc: undefined,
75-
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 31, 3))
73+
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 29, 3))
7674
>undefined : Symbol(undefined)
7775

7876
cb: n => n.toFixed()
79-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 32, 20))
80-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 33, 7))
77+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 30, 20))
78+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 31, 7))
8179
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
82-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 33, 7))
80+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 31, 7))
8381
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
8482

8583
});
8684

8785
// requires checking type information since discriminator is missing from object
8886
f({
89-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
90-
91-
cb: n => n.toFixed()
92-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 37, 3))
93-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 38, 7))
94-
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
95-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 38, 7))
96-
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
97-
98-
});
99-
100-
101-
declare function g(options: DiscriminatorTrue | DiscriminatorFalse | Unrelated): any;
102-
>g : Symbol(g, Decl(discriminantPropertyInference.ts, 39, 3))
103-
>options : Symbol(options, Decl(discriminantPropertyInference.ts, 42, 19))
104-
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(discriminantPropertyInference.ts, 0, 0))
105-
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(discriminantPropertyInference.ts, 5, 1))
106-
>Unrelated : Symbol(Unrelated, Decl(discriminantPropertyInference.ts, 10, 1))
107-
108-
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
109-
g({
110-
>g : Symbol(g, Decl(discriminantPropertyInference.ts, 39, 3))
87+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
11188

11289
cb: n => n.toFixed()
113-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 45, 3))
114-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 46, 7))
90+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 35, 3))
91+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 36, 7))
11592
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
116-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 46, 7))
93+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 36, 7))
11794
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
11895

11996
});

‎tests/baselines/reference/discriminantPropertyInference.types‎

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,8 @@ type DiscriminatorFalse = {
2525
>x : number
2626
}
2727

28-
type Unrelated = {
29-
>Unrelated : Unrelated
30-
31-
val: number;
32-
>val : number
33-
}
28+
type Props = DiscriminatorTrue | DiscriminatorFalse;
29+
>Props : Props
3430

3531
declare function f(options: DiscriminatorTrue | DiscriminatorFalse): any;
3632
>f : (options: DiscriminatorTrue | DiscriminatorFalse) => any
@@ -115,25 +111,3 @@ f({
115111

116112
});
117113

118-
119-
declare function g(options: DiscriminatorTrue | DiscriminatorFalse | Unrelated): any;
120-
>g : (options: DiscriminatorTrue | DiscriminatorFalse | Unrelated) => any
121-
>options : DiscriminatorTrue | DiscriminatorFalse | Unrelated
122-
123-
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
124-
g({
125-
>g({ cb: n => n.toFixed()}) : any
126-
>g : (options: DiscriminatorTrue | DiscriminatorFalse | Unrelated) => any
127-
>{ cb: n => n.toFixed()} : { cb: (n: number) => string; }
128-
129-
cb: n => n.toFixed()
130-
>cb : (n: number) => string
131-
>n => n.toFixed() : (n: number) => string
132-
>n : number
133-
>n.toFixed() : string
134-
>n.toFixed : (fractionDigits?: number | undefined) => string
135-
>n : number
136-
>toFixed : (fractionDigits?: number | undefined) => string
137-
138-
});
139-

‎tests/baselines/reference/tsxDiscriminantPropertyInference.js‎

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,9 @@ type DiscriminatorFalse = {
1414
cb: (x: number) => void;
1515
}
1616

17-
type Unrelated = {
18-
val: number;
19-
}
20-
2117
type Props = DiscriminatorTrue | DiscriminatorFalse;
2218

23-
type UnrelatedProps = Props | Unrelated;
24-
25-
declare function Comp(props: Props): JSX.Element;
19+
declare function Comp(props: DiscriminatorTrue | DiscriminatorFalse): JSX.Element;
2620

2721
// simple inference
2822
void (<Comp disc cb={s => parseInt(s)} />);
@@ -35,11 +29,6 @@ void (<Comp disc={undefined} cb={n => n.toFixed()} />);
3529

3630
// requires checking type information since discriminator is missing from object
3731
void (<Comp cb={n => n.toFixed()} />);
38-
39-
declare function UnrelatedComp(props: UnrelatedProps): JSX.Element;
40-
41-
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
42-
void (<Comp cb={n => n.toFixed()} />);
4332

4433

4534
//// [tsxDiscriminantPropertyInference.jsx]
@@ -51,5 +40,3 @@ void (<Comp disc={false} cb={function (n) { return n.toFixed(); }}/>);
5140
void (<Comp disc={undefined} cb={function (n) { return n.toFixed(); }}/>);
5241
// requires checking type information since discriminator is missing from object
5342
void (<Comp cb={function (n) { return n.toFixed(); }}/>);
54-
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
55-
void (<Comp cb={function (n) { return n.toFixed(); }}/>);

‎tests/baselines/reference/tsxDiscriminantPropertyInference.symbols‎

Lines changed: 25 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -29,82 +29,55 @@ type DiscriminatorFalse = {
2929
>x : Symbol(x, Decl(tsxDiscriminantPropertyInference.tsx, 12, 9))
3030
}
3131

32-
type Unrelated = {
33-
>Unrelated : Symbol(Unrelated, Decl(tsxDiscriminantPropertyInference.tsx, 13, 1))
34-
35-
val: number;
36-
>val : Symbol(val, Decl(tsxDiscriminantPropertyInference.tsx, 15, 18))
37-
}
38-
3932
type Props = DiscriminatorTrue | DiscriminatorFalse;
40-
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 1))
33+
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 13, 1))
4134
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(tsxDiscriminantPropertyInference.tsx, 3, 1))
4235
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(tsxDiscriminantPropertyInference.tsx, 8, 1))
4336

44-
type UnrelatedProps = Props | Unrelated;
45-
>UnrelatedProps : Symbol(UnrelatedProps, Decl(tsxDiscriminantPropertyInference.tsx, 19, 52))
46-
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 1))
47-
>Unrelated : Symbol(Unrelated, Decl(tsxDiscriminantPropertyInference.tsx, 13, 1))
48-
49-
declare function Comp(props: Props): JSX.Element;
50-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
51-
>props : Symbol(props, Decl(tsxDiscriminantPropertyInference.tsx, 23, 22))
52-
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 1))
37+
declare function Comp(props: DiscriminatorTrue | DiscriminatorFalse): JSX.Element;
38+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
39+
>props : Symbol(props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 22))
40+
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(tsxDiscriminantPropertyInference.tsx, 3, 1))
41+
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(tsxDiscriminantPropertyInference.tsx, 8, 1))
5342
>JSX : Symbol(JSX, Decl(tsxDiscriminantPropertyInference.tsx, 0, 0))
5443
>Element : Symbol(JSX.Element, Decl(tsxDiscriminantPropertyInference.tsx, 1, 15))
5544

5645
// simple inference
5746
void (<Comp disc cb={s => parseInt(s)} />);
58-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
59-
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 26, 11))
60-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 26, 16))
61-
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 26, 21))
47+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
48+
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 20, 11))
49+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 20, 16))
50+
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 20, 21))
6251
>parseInt : Symbol(parseInt, Decl(lib.es5.d.ts, --, --))
63-
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 26, 21))
52+
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 20, 21))
6453

6554
// simple inference
6655
void (<Comp disc={false} cb={n => n.toFixed()} />);
67-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
68-
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 29, 11))
69-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 29, 24))
70-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 29))
56+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
57+
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 23, 11))
58+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 23, 24))
59+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 23, 29))
7160
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
72-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 29))
61+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 23, 29))
7362
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
7463

7564
// simple inference when strict-null-checks are enabled
7665
void (<Comp disc={undefined} cb={n => n.toFixed()} />);
77-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
78-
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 32, 11))
66+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
67+
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 26, 11))
7968
>undefined : Symbol(undefined)
80-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 32, 28))
81-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 32, 33))
69+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 26, 28))
70+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 26, 33))
8271
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
83-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 32, 33))
72+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 26, 33))
8473
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
8574

8675
// requires checking type information since discriminator is missing from object
8776
void (<Comp cb={n => n.toFixed()} />);
88-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
89-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 35, 11))
90-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 35, 16))
91-
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
92-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 35, 16))
93-
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
94-
95-
declare function UnrelatedComp(props: UnrelatedProps): JSX.Element;
96-
>UnrelatedComp : Symbol(UnrelatedComp, Decl(tsxDiscriminantPropertyInference.tsx, 35, 38))
97-
>props : Symbol(props, Decl(tsxDiscriminantPropertyInference.tsx, 37, 31))
98-
>UnrelatedProps : Symbol(UnrelatedProps, Decl(tsxDiscriminantPropertyInference.tsx, 19, 52))
99-
>JSX : Symbol(JSX, Decl(tsxDiscriminantPropertyInference.tsx, 0, 0))
100-
>Element : Symbol(JSX.Element, Decl(tsxDiscriminantPropertyInference.tsx, 1, 15))
101-
102-
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
103-
void (<Comp cb={n => n.toFixed()} />);
104-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
105-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 40, 11))
106-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 40, 16))
77+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
78+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 29, 11))
79+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 16))
10780
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
108-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 40, 16))
81+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 16))
10982
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
11083

0 commit comments

Comments
 (0)