Skip to content

Commit 751c114

Browse files
erikbrinkmanerikbrinkman
authored
Fix contextual discrimination for omitted members (microsoft#43937)
In short, the fix I submitted looked at the union ofproperties, but it really should have looked at the intersection. Two sytlistic notes. I couldn't find the best way to get the unique strings of an array like `[...new Set()]` would, so I created a small helper function, but didn't put it in a great place. Also, before the second concatenated array of discriminators at least matched the first in complexity, but now it's much worse. I don't think that section is particularly easy to read, but I also don't see a significantly reusable part. fixes microsoft#41759
1 parent ae62da9 commit 751c114

9 files changed

+237
-67
lines changed

‎src/compiler/checker.ts‎

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26656,6 +26656,13 @@ namespace ts {
2665626656
return false;
2665726657
}
2665826658

26659+
function uniqueStrings(strings: readonly __String[]): __String[] {
26660+
const unique = new Set(strings);
26661+
const result: __String[] = [];
26662+
unique.forEach(str => result.push(str));
26663+
return result;
26664+
}
26665+
2665926666
function discriminateContextualTypeByObjectMembers(node: ObjectLiteralExpression, contextualType: UnionType) {
2666026667
return getMatchingUnionConstituentForObjectLiteral(contextualType, node) || discriminateTypeByDiscriminableItems(contextualType,
2666126668
concatenate(
@@ -26664,8 +26671,13 @@ namespace ts {
2666426671
prop => ([() => getContextFreeTypeOfExpression((prop as PropertyAssignment).initializer), prop.symbol.escapedName] as [() => Type, __String])
2666526672
),
2666626673
map(
26667-
filter(getPropertiesOfType(contextualType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26668-
s => [() => undefinedType, s.escapedName] as [() => Type, __String]
26674+
uniqueStrings(flatMap(contextualType.types, memberType =>
26675+
map(
26676+
filter(getPropertiesOfType(memberType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26677+
s => s.escapedName
26678+
)
26679+
)),
26680+
name => [() => undefinedType, name] as [() => Type, __String]
2666926681
)
2667026682
),
2667126683
isTypeAssignableTo,
@@ -26681,8 +26693,13 @@ namespace ts {
2668126693
prop => ([!(prop as JsxAttribute).initializer ? (() => trueType) : (() => getContextFreeTypeOfExpression((prop as JsxAttribute).initializer!)), prop.symbol.escapedName] as [() => Type, __String])
2668226694
),
2668326695
map(
26684-
filter(getPropertiesOfType(contextualType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26685-
s => [() => undefinedType, s.escapedName] as [() => Type, __String]
26696+
uniqueStrings(flatMap(contextualType.types, memberType =>
26697+
map(
26698+
filter(getPropertiesOfType(memberType), s => !!(s.flags & SymbolFlags.Optional) && !!node?.symbol?.members && !node.symbol.members.has(s.escapedName) && isDiscriminantProperty(contextualType, s.escapedName)),
26699+
s => s.escapedName
26700+
)
26701+
)),
26702+
name => [() => undefinedType, name] as [() => Type, __String]
2668626703
)
2668726704
),
2668826705
isTypeAssignableTo,

‎tests/baselines/reference/discriminantPropertyInference.js‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ type DiscriminatorFalse = {
1111
cb: (x: number) => void;
1212
}
1313

14-
type Props = DiscriminatorTrue | DiscriminatorFalse;
14+
type Unrelated = {
15+
val: number;
16+
}
1517

1618
declare function f(options: DiscriminatorTrue | DiscriminatorFalse): any;
1719

@@ -37,6 +39,14 @@ f({
3739
f({
3840
cb: n => n.toFixed()
3941
});
42+
43+
44+
declare function g(options: DiscriminatorTrue | DiscriminatorFalse | Unrelated): any;
45+
46+
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
47+
g({
48+
cb: n => n.toFixed()
49+
});
4050

4151

4252
//// [discriminantPropertyInference.js]
@@ -60,3 +70,7 @@ f({
6070
f({
6171
cb: function (n) { return n.toFixed(); }
6272
});
73+
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
74+
g({
75+
cb: function (n) { return n.toFixed(); }
76+
});

‎tests/baselines/reference/discriminantPropertyInference.symbols‎

Lines changed: 48 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -23,74 +23,97 @@ type DiscriminatorFalse = {
2323
>x : Symbol(x, Decl(discriminantPropertyInference.ts, 9, 9))
2424
}
2525

26-
type Props = DiscriminatorTrue | DiscriminatorFalse;
27-
>Props : Symbol(Props, Decl(discriminantPropertyInference.ts, 10, 1))
28-
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(discriminantPropertyInference.ts, 0, 0))
29-
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(discriminantPropertyInference.ts, 5, 1))
26+
type Unrelated = {
27+
>Unrelated : Symbol(Unrelated, Decl(discriminantPropertyInference.ts, 10, 1))
28+
29+
val: number;
30+
>val : Symbol(val, Decl(discriminantPropertyInference.ts, 12, 18))
31+
}
3032

3133
declare function f(options: DiscriminatorTrue | DiscriminatorFalse): any;
32-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
33-
>options : Symbol(options, Decl(discriminantPropertyInference.ts, 14, 19))
34+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
35+
>options : Symbol(options, Decl(discriminantPropertyInference.ts, 16, 19))
3436
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(discriminantPropertyInference.ts, 0, 0))
3537
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(discriminantPropertyInference.ts, 5, 1))
3638

3739
// simple inference
3840
f({
39-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
41+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
4042

4143
disc: true,
42-
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 17, 3))
44+
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 19, 3))
4345

4446
cb: s => parseInt(s)
45-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 18, 15))
46-
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 19, 7))
47+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 20, 15))
48+
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 21, 7))
4749
>parseInt : Symbol(parseInt, Decl(lib.es5.d.ts, --, --))
48-
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 19, 7))
50+
>s : Symbol(s, Decl(discriminantPropertyInference.ts, 21, 7))
4951

5052
});
5153

5254
// simple inference
5355
f({
54-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
56+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
5557

5658
disc: false,
57-
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 23, 3))
59+
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 25, 3))
5860

5961
cb: n => n.toFixed()
60-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 24, 16))
61-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 25, 7))
62+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 26, 16))
63+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 27, 7))
6264
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
63-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 25, 7))
65+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 27, 7))
6466
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
6567

6668
});
6769

6870
// simple inference when strict-null-checks are enabled
6971
f({
70-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
72+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
7173

7274
disc: undefined,
73-
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 29, 3))
75+
>disc : Symbol(disc, Decl(discriminantPropertyInference.ts, 31, 3))
7476
>undefined : Symbol(undefined)
7577

7678
cb: n => n.toFixed()
77-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 30, 20))
78-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 31, 7))
79+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 32, 20))
80+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 33, 7))
7981
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
80-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 31, 7))
82+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 33, 7))
8183
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
8284

8385
});
8486

8587
// requires checking type information since discriminator is missing from object
8688
f({
87-
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 12, 52))
89+
>f : Symbol(f, Decl(discriminantPropertyInference.ts, 14, 1))
90+
91+
cb: n => n.toFixed()
92+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 37, 3))
93+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 38, 7))
94+
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
95+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 38, 7))
96+
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
97+
98+
});
99+
100+
101+
declare function g(options: DiscriminatorTrue | DiscriminatorFalse | Unrelated): any;
102+
>g : Symbol(g, Decl(discriminantPropertyInference.ts, 39, 3))
103+
>options : Symbol(options, Decl(discriminantPropertyInference.ts, 42, 19))
104+
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(discriminantPropertyInference.ts, 0, 0))
105+
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(discriminantPropertyInference.ts, 5, 1))
106+
>Unrelated : Symbol(Unrelated, Decl(discriminantPropertyInference.ts, 10, 1))
107+
108+
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
109+
g({
110+
>g : Symbol(g, Decl(discriminantPropertyInference.ts, 39, 3))
88111

89112
cb: n => n.toFixed()
90-
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 35, 3))
91-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 36, 7))
113+
>cb : Symbol(cb, Decl(discriminantPropertyInference.ts, 45, 3))
114+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 46, 7))
92115
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
93-
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 36, 7))
116+
>n : Symbol(n, Decl(discriminantPropertyInference.ts, 46, 7))
94117
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
95118

96119
});

‎tests/baselines/reference/discriminantPropertyInference.types‎

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,12 @@ type DiscriminatorFalse = {
2525
>x : number
2626
}
2727

28-
type Props = DiscriminatorTrue | DiscriminatorFalse;
29-
>Props : Props
28+
type Unrelated = {
29+
>Unrelated : Unrelated
30+
31+
val: number;
32+
>val : number
33+
}
3034

3135
declare function f(options: DiscriminatorTrue | DiscriminatorFalse): any;
3236
>f : (options: DiscriminatorTrue | DiscriminatorFalse) => any
@@ -111,3 +115,25 @@ f({
111115

112116
});
113117

118+
119+
declare function g(options: DiscriminatorTrue | DiscriminatorFalse | Unrelated): any;
120+
>g : (options: DiscriminatorTrue | DiscriminatorFalse | Unrelated) => any
121+
>options : DiscriminatorTrue | DiscriminatorFalse | Unrelated
122+
123+
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
124+
g({
125+
>g({ cb: n => n.toFixed()}) : any
126+
>g : (options: DiscriminatorTrue | DiscriminatorFalse | Unrelated) => any
127+
>{ cb: n => n.toFixed()} : { cb: (n: number) => string; }
128+
129+
cb: n => n.toFixed()
130+
>cb : (n: number) => string
131+
>n => n.toFixed() : (n: number) => string
132+
>n : number
133+
>n.toFixed() : string
134+
>n.toFixed : (fractionDigits?: number | undefined) => string
135+
>n : number
136+
>toFixed : (fractionDigits?: number | undefined) => string
137+
138+
});
139+

‎tests/baselines/reference/tsxDiscriminantPropertyInference.js‎

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,15 @@ type DiscriminatorFalse = {
1414
cb: (x: number) => void;
1515
}
1616

17+
type Unrelated = {
18+
val: number;
19+
}
20+
1721
type Props = DiscriminatorTrue | DiscriminatorFalse;
1822

19-
declare function Comp(props: DiscriminatorTrue | DiscriminatorFalse): JSX.Element;
23+
type UnrelatedProps = Props | Unrelated;
24+
25+
declare function Comp(props: Props): JSX.Element;
2026

2127
// simple inference
2228
void (<Comp disc cb={s => parseInt(s)} />);
@@ -29,6 +35,11 @@ void (<Comp disc={undefined} cb={n => n.toFixed()} />);
2935

3036
// requires checking type information since discriminator is missing from object
3137
void (<Comp cb={n => n.toFixed()} />);
38+
39+
declare function UnrelatedComp(props: UnrelatedProps): JSX.Element;
40+
41+
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
42+
void (<Comp cb={n => n.toFixed()} />);
3243

3344

3445
//// [tsxDiscriminantPropertyInference.jsx]
@@ -40,3 +51,5 @@ void (<Comp disc={false} cb={function (n) { return n.toFixed(); }}/>);
4051
void (<Comp disc={undefined} cb={function (n) { return n.toFixed(); }}/>);
4152
// requires checking type information since discriminator is missing from object
4253
void (<Comp cb={function (n) { return n.toFixed(); }}/>);
54+
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
55+
void (<Comp cb={function (n) { return n.toFixed(); }}/>);

‎tests/baselines/reference/tsxDiscriminantPropertyInference.symbols‎

Lines changed: 52 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -29,55 +29,82 @@ type DiscriminatorFalse = {
2929
>x : Symbol(x, Decl(tsxDiscriminantPropertyInference.tsx, 12, 9))
3030
}
3131

32+
type Unrelated = {
33+
>Unrelated : Symbol(Unrelated, Decl(tsxDiscriminantPropertyInference.tsx, 13, 1))
34+
35+
val: number;
36+
>val : Symbol(val, Decl(tsxDiscriminantPropertyInference.tsx, 15, 18))
37+
}
38+
3239
type Props = DiscriminatorTrue | DiscriminatorFalse;
33-
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 13, 1))
40+
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 1))
3441
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(tsxDiscriminantPropertyInference.tsx, 3, 1))
3542
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(tsxDiscriminantPropertyInference.tsx, 8, 1))
3643

37-
declare function Comp(props: DiscriminatorTrue | DiscriminatorFalse): JSX.Element;
38-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
39-
>props : Symbol(props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 22))
40-
>DiscriminatorTrue : Symbol(DiscriminatorTrue, Decl(tsxDiscriminantPropertyInference.tsx, 3, 1))
41-
>DiscriminatorFalse : Symbol(DiscriminatorFalse, Decl(tsxDiscriminantPropertyInference.tsx, 8, 1))
44+
type UnrelatedProps = Props | Unrelated;
45+
>UnrelatedProps : Symbol(UnrelatedProps, Decl(tsxDiscriminantPropertyInference.tsx, 19, 52))
46+
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 1))
47+
>Unrelated : Symbol(Unrelated, Decl(tsxDiscriminantPropertyInference.tsx, 13, 1))
48+
49+
declare function Comp(props: Props): JSX.Element;
50+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
51+
>props : Symbol(props, Decl(tsxDiscriminantPropertyInference.tsx, 23, 22))
52+
>Props : Symbol(Props, Decl(tsxDiscriminantPropertyInference.tsx, 17, 1))
4253
>JSX : Symbol(JSX, Decl(tsxDiscriminantPropertyInference.tsx, 0, 0))
4354
>Element : Symbol(JSX.Element, Decl(tsxDiscriminantPropertyInference.tsx, 1, 15))
4455

4556
// simple inference
4657
void (<Comp disc cb={s => parseInt(s)} />);
47-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
48-
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 20, 11))
49-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 20, 16))
50-
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 20, 21))
58+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
59+
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 26, 11))
60+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 26, 16))
61+
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 26, 21))
5162
>parseInt : Symbol(parseInt, Decl(lib.es5.d.ts, --, --))
52-
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 20, 21))
63+
>s : Symbol(s, Decl(tsxDiscriminantPropertyInference.tsx, 26, 21))
5364

5465
// simple inference
5566
void (<Comp disc={false} cb={n => n.toFixed()} />);
56-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
57-
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 23, 11))
58-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 23, 24))
59-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 23, 29))
67+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
68+
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 29, 11))
69+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 29, 24))
70+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 29))
6071
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
61-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 23, 29))
72+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 29))
6273
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
6374

6475
// simple inference when strict-null-checks are enabled
6576
void (<Comp disc={undefined} cb={n => n.toFixed()} />);
66-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
67-
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 26, 11))
77+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
78+
>disc : Symbol(disc, Decl(tsxDiscriminantPropertyInference.tsx, 32, 11))
6879
>undefined : Symbol(undefined)
69-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 26, 28))
70-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 26, 33))
80+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 32, 28))
81+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 32, 33))
7182
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
72-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 26, 33))
83+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 32, 33))
7384
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
7485

7586
// requires checking type information since discriminator is missing from object
7687
void (<Comp cb={n => n.toFixed()} />);
77-
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 15, 52))
78-
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 29, 11))
79-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 16))
88+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
89+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 35, 11))
90+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 35, 16))
91+
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
92+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 35, 16))
93+
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
94+
95+
declare function UnrelatedComp(props: UnrelatedProps): JSX.Element;
96+
>UnrelatedComp : Symbol(UnrelatedComp, Decl(tsxDiscriminantPropertyInference.tsx, 35, 38))
97+
>props : Symbol(props, Decl(tsxDiscriminantPropertyInference.tsx, 37, 31))
98+
>UnrelatedProps : Symbol(UnrelatedProps, Decl(tsxDiscriminantPropertyInference.tsx, 19, 52))
99+
>JSX : Symbol(JSX, Decl(tsxDiscriminantPropertyInference.tsx, 0, 0))
100+
>Element : Symbol(JSX.Element, Decl(tsxDiscriminantPropertyInference.tsx, 1, 15))
101+
102+
// requires checking properties of all types, rather than properties of just the union type (e.g. only intersection)
103+
void (<Comp cb={n => n.toFixed()} />);
104+
>Comp : Symbol(Comp, Decl(tsxDiscriminantPropertyInference.tsx, 21, 40))
105+
>cb : Symbol(cb, Decl(tsxDiscriminantPropertyInference.tsx, 40, 11))
106+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 40, 16))
80107
>n.toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
81-
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 29, 16))
108+
>n : Symbol(n, Decl(tsxDiscriminantPropertyInference.tsx, 40, 16))
82109
>toFixed : Symbol(Number.toFixed, Decl(lib.es5.d.ts, --, --))
83110

0 commit comments

Comments
 (0)