Skip to content

Commit 4ec9978

Browse files
authored
Merge pull request #829 from ashawley/roundtrip-serialization
Check roundtrip in serialize tests
2 parents 4dc0ef2 + 8621013 commit 4ec9978

File tree

1 file changed

+8
-20
lines changed

1 file changed

+8
-20
lines changed

jvm/src/test/scala/org/scalacheck/SerializabilitySpecification.scala

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,51 +19,39 @@ import util.SerializableCanBuildFroms._
1919
object SerializabilitySpecification extends Properties("Serializability") {
2020

2121
def serializable[M <: Serializable](m: M): Boolean = {
22-
val arr = serialize(m)
23-
null != arr && arr.nonEmpty
24-
}
25-
26-
def serialize[T <: Serializable](in: T): Array[Byte] = {
27-
SerializationUtils.serialize(in)
22+
SerializationUtils.roundtrip(m)
23+
true
2824
}
2925

3026
def serializableArbitrary[T: Arbitrary](name: String) =
3127
property(s"Arbitrary[$name]") = {
3228
val arb = implicitly[Arbitrary[T]]
33-
assert(serializable(arb))
29+
serializable(arb)
3430

3531
// forcing the calculation of a value, to trigger the initialization of any lazily initialized field
3632
arb.arbitrary.sample
37-
assert(serializable(arb))
38-
39-
proved
33+
serializable(arb)
4034
}
4135

4236
def serializableGen[T](name: String, gen: Gen[T]) =
4337
property(name) = {
44-
assert(serializable(gen))
38+
serializable(gen)
4539

4640
// forcing the calculation of a value, to trigger the initialization of any lazily initialized field
4741
gen.sample
48-
assert(serializable(gen))
49-
50-
proved
42+
serializable(gen)
5143
}
5244

5345
def serializableCogen[T: Cogen](name: String) =
5446
property(s"Cogen[$name]") = {
5547
val gen = Cogen[T]
56-
assert(serializable(gen))
57-
58-
proved
48+
serializable(gen)
5949
}
6050

6151
def serializableShrink[T: Shrink](name: String) =
6252
property(s"Shrink[$name]") = {
6353
val shrink = implicitly[Shrink[T]]
64-
assert(serializable(shrink))
65-
66-
proved
54+
serializable(shrink)
6755
}
6856

6957
serializableArbitrary[String]("String")

0 commit comments

Comments
 (0)