Fix missing at runtime errors (second batch) (#2636)

* `LogoutView.get_next_page` renamed to `get_success_url` in 4.1

* Removed in 5.2  (`create_spatial_indexes`)

* Remove `admin_list.DOT` symbol

* Remove `INTERNAL_RESET_URL_TOKEN`

* Remove `PostGISAdapter.prepare`

Removed in 4.2 https://github.com/django/django/blob/stable/4.2.x/django/contrib/gis/db/backends/postgis/adapter.py

* QuerySet does not implement `__reversed__`

AttributeError: 'QuerySet' object has no attribute '__reversed__'

* Fix `psycopg2_version` types

* InvalidQuery removed in 4.0

* The ``django.db.models.query_utils.InvalidQuery`` exception class is removed.

* `save_m2m` is dynamically added on modelforms

* Remove ifequal nodes

* MultiColSource removed in django 5.2

Author: UnknownPlatypus

django-stubs/contrib/admin/templatetags/admin_list.pyi

@@ -13,7 +13,6 @@ from django.utils.safestring import SafeString
 from .base import InclusionAdminNode
 
 register: Any
-DOT: str
 
 def paginator_number(cl: ChangeList, i: int) -> SafeString: ...
 def pagination(cl: ChangeList) -> dict[str, Any]: ...

django-stubs/contrib/auth/views.pyi

@@ -31,7 +31,6 @@ class LogoutView(RedirectURLMixin, TemplateView):
     extra_context: Any
     def dispatch(self, request: HttpRequest, *args: Any, **kwargs: Any) -> HttpResponse: ...
     def post(self, request: HttpRequest, *args: Any, **kwargs: Any) -> HttpResponse: ...
-    def get_next_page(self) -> str | None: ...
 
 def logout_then_login(request: HttpRequest, login_url: str | None = ...) -> HttpResponseRedirect: ...
 def redirect_to_login(
@@ -51,7 +50,6 @@ class PasswordResetView(PasswordContextMixin, FormView):
     title: Any
     token_generator: Any
 
-INTERNAL_RESET_URL_TOKEN: str
 INTERNAL_RESET_SESSION_TOKEN: str
 
 class PasswordResetDoneView(PasswordContextMixin, TemplateView):

django-stubs/contrib/gis/db/backends/mysql/schema.pyi

@@ -19,4 +19,3 @@ class MySQLGISSchemaEditor(DatabaseSchemaEditor):
     def create_model(self, model: type[Model]) -> None: ...
     def add_field(self, model: type[Model], field: Field) -> None: ...
     def remove_field(self, model: type[Model], field: Field) -> None: ...
-    def create_spatial_indexes(self) -> None: ...

django-stubs/contrib/gis/db/backends/postgis/adapter.pyi

@@ -9,5 +9,4 @@ class PostGISAdapter:
     def __conform__(self, proto: Any) -> Any: ...
     def __eq__(self, other: object) -> bool: ...
     def __hash__(self) -> int: ...
-    def prepare(self, conn: Any) -> None: ...
     def getquoted(self) -> Any: ...

django-stubs/db/backends/postgresql/base.pyi

@@ -12,9 +12,7 @@ from .features import DatabaseFeatures
 from .introspection import DatabaseIntrospection
 from .operations import DatabaseOperations
 
-def psycopg2_version() -> tuple[int, ...]: ...
-
-PSYCOPG2_VERSION: tuple[int, ...]
+def psycopg_version() -> tuple[int, int, int]: ...
 
 class DatabaseWrapper(BaseDatabaseWrapper):
     client: DatabaseClient

django-stubs/db/models/fields/related_lookups.pyi

@@ -1,30 +1,7 @@
-from collections.abc import Iterable, Mapping
+from collections.abc import Iterable
 from typing import Any
 
-from django.db.models.fields import Field
-from django.db.models.lookups import (
-    Exact,
-    GreaterThan,
-    GreaterThanOrEqual,
-    In,
-    IsNull,
-    LessThan,
-    LessThanOrEqual,
-    Lookup,
-)
-
-class MultiColSource:
-    alias: str
-    field: Field
-    sources: tuple[Field, Field]
-    targets: tuple[Field, Field]
-    contains_aggregate: bool
-    output_field: Field
-    def __init__(
-        self, alias: str, targets: tuple[Field, Field], sources: tuple[Field, Field], field: Field
-    ) -> None: ...
-    def relabeled_clone(self, relabels: Mapping[str, str]) -> MultiColSource: ...
-    def get_lookup(self, lookup: str) -> type[Lookup] | None: ...
+from django.db.models.lookups import Exact, GreaterThan, GreaterThanOrEqual, In, IsNull, LessThan, LessThanOrEqual
 
 def get_normalized_value(value: Any, lhs: Any) -> tuple[Any, ...]: ...
 

django-stubs/db/models/query.pyi

@@ -192,7 +192,6 @@ class QuerySet(Generic[_Model, _Row], Iterable[_Row], Sized):
     def __getitem__(self, i: int) -> _Row: ...
     @overload
     def __getitem__(self, s: slice) -> Self: ...
-    def __reversed__(self) -> Iterator[_Row]: ...
 
 class RawQuerySet(Iterable[_Model], Sized):
     query: RawQuery

django-stubs/db/models/query_utils.pyi

@@ -19,8 +19,6 @@ PathInfo = namedtuple(
     "PathInfo", ["from_opts", "to_opts", "target_fields", "join_field", "m2m", "direct", "filtered_relation"]
 )
 
-class InvalidQuery(Exception): ...
-
 def subclasses(cls: type[RegisterLookupMixin]) -> Iterator[type[RegisterLookupMixin]]: ...
 
 class Q(tree.Node):

django-stubs/template/defaulttags.pyi

@@ -65,22 +65,6 @@ class IfChangedNode(Node):
     child_nodelists: Any
     def __init__(self, nodelist_true: NodeList, nodelist_false: NodeList, *varlist: Any) -> None: ...
 
-class IfEqualNode(Node):
-    nodelist_false: list[Any] | NodeList
-    nodelist_true: list[Any] | NodeList
-    var1: FilterExpression | str
-    var2: FilterExpression | str
-    child_nodelists: Any
-    negate: bool
-    def __init__(
-        self,
-        var1: FilterExpression | str,
-        var2: FilterExpression | str,
-        nodelist_true: list[Any] | NodeList,
-        nodelist_false: list[Any] | NodeList,
-        negate: bool,
-    ) -> None: ...
-
 class IfNode(Node):
     conditions_nodelists: list[tuple[TemplateLiteral | None, NodeList]]
     def __init__(self, conditions_nodelists: list[tuple[TemplateLiteral | None, NodeList]]) -> None: ...
@@ -172,9 +156,6 @@ def debug(parser: Parser, token: Token) -> DebugNode: ...
 def do_filter(parser: Parser, token: Token) -> FilterNode: ...
 def firstof(parser: Parser, token: Token) -> FirstOfNode: ...
 def do_for(parser: Parser, token: Token) -> ForNode: ...
-def do_ifequal(parser: Parser, token: Token, negate: bool) -> IfEqualNode: ...
-def ifequal(parser: Parser, token: Token) -> IfEqualNode: ...
-def ifnotequal(parser: Parser, token: Token) -> IfEqualNode: ...
 
 class TemplateLiteral(Literal):
     text: str

scripts/stubtest/allowlist.txt

@@ -538,3 +538,12 @@ django.db.models.fields.generated.GeneratedField.__init__
 # https://github.com/python/cpython/blob/5abff6960b4aecb0d5c81c7482cf3faa74e1983d/Lib/copyreg.py#L112-L161
 # Some Django classes get copied at import time, which leads stubtest to detect it.
 .*\.__slotnames__
+
+# These are dynamically added when using `save(commit=False)`
+# See https://docs.djangoproject.com/en/5.2/topics/forms/modelforms/#the-save-method
+django.forms.BaseModelForm.save_m2m
+django.forms.BaseModelFormSet.save_m2m
+django.forms.models.BaseModelForm.save_m2m
+django.forms.models.BaseModelFormSet.save_m2m
+django.contrib.gis.forms.BaseModelForm.save_m2m
+django.contrib.gis.forms.BaseModelFormSet.save_m2m