Skip to content

Commit 8d4b381

Browse files
JasonLovesDoggopre-commit-ci[bot]adamchainz
authored
Make GeneratedField parameter db_persist required (#2568)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Adam Johnson <me@adamj.eu>
1 parent e1de864 commit 8d4b381

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

django-stubs/db/models/fields/generated.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class GeneratedField(models.Field):
2222
*,
2323
expression: Expression,
2424
output_field: models.Field,
25-
db_persist: bool | None = None,
25+
db_persist: bool,
2626
verbose_name: _StrOrPromise | None = ...,
2727
name: str | None = ...,
2828
primary_key: bool = ...,

scripts/stubtest/allowlist.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,3 +510,10 @@ django.db.models.Model.asave
510510
django.db.models.Model.save
511511
django.db.models.base.Model.asave
512512
django.db.models.base.Model.save
513+
514+
# Ignore: GeneratedField.__init__ is inconsistent, runtime argument "db_persist" has a default value but stub argument does not
515+
# The default value None never worked and has been dropped for Django 6.0:
516+
# https://code.djangoproject.com/ticket/36262
517+
django.contrib.gis.db.models.GeneratedField.__init__
518+
django.db.models.GeneratedField.__init__
519+
django.db.models.fields.generated.GeneratedField.__init__

0 commit comments

Comments
 (0)