Skip to content

Commit 26cf5f9

Browse files
authored
Remove unused code from the plugin (#2570)
1 parent 19e63f2 commit 26cf5f9

File tree

4 files changed

+1
-24
lines changed

4 files changed

+1
-24
lines changed

mypy_django_plugin/errorcodes.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
from mypy.errorcodes import ErrorCode
22

3-
MANAGER_UNTYPED = ErrorCode("django-manager", "Untyped manager disallowed", "Django")
43
MANAGER_MISSING = ErrorCode("django-manager-missing", "Couldn't resolve manager for model", "Django")

mypy_django_plugin/lib/fullnames.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@
44
MODEL_METACLASS_FULLNAME = "django.db.models.base.ModelBase"
55
MODEL_CLASS_FULLNAME = "django.db.models.base.Model"
66
FIELD_FULLNAME = "django.db.models.fields.Field"
7-
CHAR_FIELD_FULLNAME = "django.db.models.fields.CharField"
87
ARRAY_FIELD_FULLNAME = "django.contrib.postgres.fields.array.ArrayField"
9-
AUTO_FIELD_FULLNAME = "django.db.models.fields.AutoField"
10-
GENERIC_FOREIGN_KEY_FULLNAME = "django.contrib.contenttypes.fields.GenericForeignKey"
118
FOREIGN_OBJECT_FULLNAME = "django.db.models.fields.related.ForeignObject"
129
FOREIGN_KEY_FULLNAME = "django.db.models.fields.related.ForeignKey"
1310
ONETOONE_FIELD_FULLNAME = "django.db.models.fields.related.OneToOneField"
@@ -29,11 +26,6 @@
2926

3027
FORM_MIXIN_CLASS_FULLNAME = "django.views.generic.edit.FormMixin"
3128

32-
MANAGER_CLASSES = {
33-
MANAGER_CLASS_FULLNAME,
34-
BASE_MANAGER_CLASS_FULLNAME,
35-
}
36-
3729
REVERSE_ONE_TO_ONE_DESCRIPTOR = "django.db.models.fields.related_descriptors.ReverseOneToOneDescriptor"
3830
REVERSE_MANY_TO_ONE_DESCRIPTOR = "django.db.models.fields.related_descriptors.ReverseManyToOneDescriptor"
3931
MANY_TO_MANY_DESCRIPTOR = "django.db.models.fields.related_descriptors.ManyToManyDescriptor"
@@ -46,9 +38,7 @@
4638
)
4739
)
4840

49-
MIGRATION_CLASS_FULLNAME = "django.db.migrations.migration.Migration"
5041
OPTIONS_CLASS_FULLNAME = "django.db.models.options.Options"
51-
HTTPREQUEST_CLASS_FULLNAME = "django.http.request.HttpRequest"
5242
QUERYDICT_CLASS_FULLNAME = "django.http.request.QueryDict"
5343

5444
COMBINABLE_EXPRESSION_FULLNAME = "django.db.models.expressions.Combinable"

mypy_django_plugin/lib/helpers.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ class DjangoTypeMetadata(TypedDict, total=False):
6464
from_queryset_manager: str
6565
reverse_managers: dict[str, str]
6666
baseform_bases: dict[str, int]
67-
manager_bases: dict[str, int]
68-
model_bases: dict[str, int]
69-
queryset_bases: dict[str, int]
7067
m2m_throughs: dict[str, str]
7168
m2m_managers: dict[str, str]
7269
manager_to_model: str
@@ -76,7 +73,7 @@ def get_django_metadata(model_info: TypeInfo) -> DjangoTypeMetadata:
7673
return cast(DjangoTypeMetadata, model_info.metadata.setdefault("django", {}))
7774

7875

79-
def get_django_metadata_bases(model_info: TypeInfo, key: Literal["baseform_bases", "queryset_bases"]) -> dict[str, int]:
76+
def get_django_metadata_bases(model_info: TypeInfo, key: Literal["baseform_bases"]) -> dict[str, int]:
8077
return get_django_metadata(model_info).setdefault(key, cast(dict[str, int], {}))
8178

8279

mypy_django_plugin/main.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,6 @@ def __init__(self, options: Options) -> None:
7070
sys.path.extend(options.mypy_path)
7171
self.django_context = DjangoContext(self.plugin_config.django_settings_module)
7272

73-
def _get_current_queryset_bases(self) -> dict[str, int]:
74-
model_sym = self.lookup_fully_qualified(fullnames.QUERYSET_CLASS_FULLNAME)
75-
if model_sym is not None and isinstance(model_sym.node, TypeInfo):
76-
bases = helpers.get_django_metadata_bases(model_sym.node, "queryset_bases")
77-
bases[fullnames.QUERYSET_CLASS_FULLNAME] = 1
78-
return bases
79-
else:
80-
return {}
81-
8273
def _get_current_form_bases(self) -> dict[str, int]:
8374
model_sym = self.lookup_fully_qualified(fullnames.BASEFORM_CLASS_FULLNAME)
8475
if model_sym is not None and isinstance(model_sym.node, TypeInfo):

0 commit comments

Comments
 (0)