#24 - Tests for the new Config module

Author: fredevery

src/scripts/core/Module.js

@@ -224,7 +224,7 @@ const Module = function (moduleObj) {
             let moduleConfigs = {};
 
             moduleAcceptsConfigs.forEach((configKey) => {
-                moduleConfigs[configKey] = optsConfigs[configKey] || {}
+                moduleConfigs[configKey] = optsConfigs[configKey] || {};
             });
 
             context.extendWith({ configs: moduleConfigs });

src/scripts/modules/Config.js

@@ -16,8 +16,7 @@ const Config = Module({
 
     methods: {
         setup () {},
-        init () {
-        },
+        init () {},
 
         getToolbarButtons () {
             const { mediator, configs } = this;

src/scripts/utils/DOM.js

@@ -537,8 +537,8 @@ const DOM = {
 
     cloneNodes (rootElem, opts={}) {
         let clonedNodes = [];
+
         rootElem.childNodes.forEach((node) => {
-            const clonedNode = node.cloneNode(true);
             clonedNodes.push(node.cloneNode(true));
         });
 

test/unit/helpers/e2eSetup.js

@@ -31,7 +31,6 @@ const e2eSetup = function () {
     new UIContainer({ mediator });
     new CanvasContainer({ mediator });
 
-
     return {
         mediator,
         editableEl

test/unit/modules/Config.spec.js

@@ -0,0 +1,62 @@
+import Mediator from '../../../src/scripts/core/Mediator';
+import Config from '../../../src/scripts/modules/Config';
+
+import toolbarConfig from '../../../src/scripts/config/toolbar';
+
+describe('modules/Config', function () {
+    let mediator;
+    const toolbarConfigsKeysStrings = function (config, source) {
+        const configKeysString = JSON.stringify(config.buttons.map((buttonConfig) => buttonConfig.configKey));
+        const sourceKeysString = JSON.stringify(source);
+        return [
+            config.buttons.length,
+            source.length,
+            configKeysString,
+            sourceKeysString
+        ];
+    };
+
+    beforeEach(() => {
+        mediator = new Mediator();
+    });
+
+    afterEach(() => {
+        mediator = null;
+    });
+
+    it('should return toolbar buttons from default toolbar config', () => {
+        new Config({ mediator });
+        const toolbarButtons = mediator.get('config:toolbar:buttons');
+        const [
+            configLength,
+            sourceLength,
+            configKeysString,
+            sourceKeysString
+        ] = toolbarConfigsKeysStrings(toolbarButtons, toolbarConfig.buttons);
+
+        expect(configLength).toBe(sourceLength);
+        expect(configKeysString).toBe(sourceKeysString);
+    });
+
+    it('should return toolbar buttons from given custom config', () => {
+        const customToolbarConfig = ['bold', 'h1', 'link'];
+        new Config({
+            mediator,
+            configs: {
+                toolbar: {
+                    buttons: customToolbarConfig
+                }
+            }
+        });
+        const toolbarButtons = mediator.get('config:toolbar:buttons');
+        const [
+            configLength,
+            sourceLength,
+            configKeysString,
+            sourceKeysString
+        ] = toolbarConfigsKeysStrings(toolbarButtons, customToolbarConfig);
+
+        expect(configLength).toBe(sourceLength);
+        expect(configKeysString).toBe(sourceKeysString);
+    });
+});