Skip to content

Commit 26b11b7

Browse files
committed
#32 - Code cleanup and minor bug fix
1 parent 3863737 commit 26b11b7

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/scripts/modules/Selection.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ const Selection = Module({
255255
let startCoordinates = [];
256256
let endCoordinates = [];
257257
let startRootChildIndex = 0;
258-
console.log('getRangeRelativeToRoot:start');
259258

260259
startCoordinates.unshift(startOffset);
261260
endCoordinates.unshift(endOffset);
@@ -279,8 +278,6 @@ const Selection = Module({
279278
endContainer = endContainer.parentNode;
280279
}
281280

282-
console.log('getRangeRelativeToRoot:end');
283-
284281
return {
285282
startCoordinates,
286283
endCoordinates
@@ -289,7 +286,7 @@ const Selection = Module({
289286

290287
rangeCoordinates () {
291288
this.ensureTextOnlySelection();
292-
console.log('rangeCoordinates:start');
289+
293290
let {
294291
startContainer,
295292
startOffset,
@@ -343,16 +340,15 @@ const Selection = Module({
343340
startCoordinates.unshift(startOffset);
344341
endCoordinates.unshift(endOffset);
345342

346-
while (!this.isContentEditable(startContainer)) {
343+
while (startContainer && !this.isContentEditable(startContainer)) {
347344
startCoordinates.unshift(DOM.childIndex(startContainer));
348345
startContainer = startContainer.parentNode;
349346
}
350347

351-
while (!this.isContentEditable(endContainer)) {
348+
while (endContainer && !this.isContentEditable(endContainer)) {
352349
endCoordinates.unshift(DOM.childIndex(endContainer));
353350
endContainer = endContainer.parentNode;
354351
}
355-
console.log('rangeCoordinates:end');
356352

357353
return {
358354
startCoordinates,

src/scripts/modules/Undo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const Undo = Module({
1212

1313
handlers: {
1414
events: {
15-
// 'contenteditable:mutation:observed': 'handleMutation',
15+
'contenteditable:mutation:observed': 'handleMutation',
1616
'contenteditable:focus': 'handleFocus',
1717
'import:from:canvas:start': 'handleImportStart',
1818
'import:from:canvas:complete': 'handleImportComplete',

0 commit comments

Comments
 (0)