fix: add hidden logCacheSize option

Author: dkundel

packages/plugin-serverless/src/utils.js

@@ -1,6 +1,6 @@
-const path = require("path");
-const camelCase = require("lodash.camelcase");
-const { flags } = require("@oclif/command");
+const path = require('path');
+const camelCase = require('lodash.camelcase');
+const { flags } = require('@oclif/command');
 
 function convertYargsOptionsToOclifFlags(options) {
   const flagsResult = Object.keys(options).reduce((result, name) => {
@@ -11,16 +11,21 @@ function convertYargsOptionsToOclifFlags(options) {
       hidden: opt.hidden,
     };
 
-    if (typeof opt.default !== "undefined") {
+    if (typeof opt.default !== 'undefined') {
       flag.default = opt.default;
 
-      if (opt.type === "boolean") {
+      if (opt.type === 'boolean') {
         if (flag.default === true) {
           flag.allowNo = true;
         }
       }
     }
 
+    if (opt.type === 'number') {
+      opt.type = 'string';
+      flag.parse = input => parseFloat(input);
+    }
+
     if (opt.alias) {
       flag.char = opt.alias;
     }
@@ -37,7 +42,7 @@ function convertYargsOptionsToOclifFlags(options) {
 
 function normalizeFlags(flags) {
   const result = Object.keys(flags).reduce((current, name) => {
-    if (name.includes("-")) {
+    if (name.includes('-')) {
       const normalizedName = camelCase(name);
       current[normalizedName] = flags[name];
     }

packages/twilio-run/src/commands/logs.ts

@@ -112,6 +112,12 @@ export const cliInfo: CliInfo = {
       describe:
         'Path to .env file for environment variables that should be installed',
     },
+    'log-cache-size': {
+      type: 'number',
+      hidden: true,
+      describe:
+        'Tailing the log endpoint will cache previously seen entries to avoid duplicates. The cache is topped at a maximum of 1000 by default. This option can change that.',
+    },
   },
 };
 

packages/twilio-run/src/config/logs.ts

@@ -32,6 +32,7 @@ export type LogsCliFlags = Arguments<
     functionSid?: string;
     tail: boolean;
     outputFormat?: string;
+    logCacheSize?: number;
   }
 >;
 
@@ -81,5 +82,6 @@ export async function getConfigFromFlags(
     tail: flags.tail,
     region,
     edge,
+    logCacheSize: flags.logCacheSize,
   };
 }