fix(twilio-run:start): changing port numbers changes output (#189)

Fixes #188.

Previously, when starting up we generated the url and optionally the ngrok tunnel before we started the server. If starting then clashed with an existing server on the port we chose and a different port was selected, the display and ngrok tunnel would still point at the original port.

This commit only generates the URL and ngrok tunnel once the server has started using the port that was ultimately selected.

Author: philnash

packages/twilio-run/src/commands/start.ts

@@ -10,6 +10,7 @@ import { getDebugFunction, logger, setLogLevelByName } from '../utils/logger';
 import { ExternalCliOptions, sharedCliOptions } from './shared';
 import { CliInfo } from './types';
 import { getFullCommand } from './utils';
+import { getUrl } from '../config/start';
 
 const debug = getDebugFunction('twilio-run:start');
 
@@ -74,9 +75,15 @@ export async function handler(
   return new Promise((resolve, reject) => {
     let attempts = 1;
     const MAX_ATTEMPTS = 3;
-    const serverStartedSuccessfully = async () => {
-      printRouteInfo(config);
-      resolve();
+    const serverStartedSuccessfully = (port?: number) => {
+      return async () => {
+        if (port) {
+          config.port = port;
+        }
+        config.url = await getUrl(argv, config.port);
+        printRouteInfo(config);
+        resolve();
+      };
     };
     const handleServerError = async (error: ServerError) => {
       if (error.code === 'EADDRINUSE') {
@@ -96,7 +103,7 @@ export async function handler(
           attempts += 1;
           const server = app.listen(
             answers.newPortNumber,
-            serverStartedSuccessfully
+            serverStartedSuccessfully(answers.newPortNumber)
           );
           server.on('error', handleServerError);
         }
@@ -105,7 +112,7 @@ export async function handler(
       }
     };
 
-    const server = app.listen(config.port, serverStartedSuccessfully);
+    const server = app.listen(config.port, serverStartedSuccessfully());
     server.on('error', handleServerError);
   });
 }

packages/twilio-run/src/config/start.ts

@@ -168,7 +168,6 @@ export async function getConfigFromCli(
   config.baseDir = getBaseDirectory(cli);
   config.env = await getEnvironment(cli, config.baseDir);
   config.port = getPort(cli);
-  config.url = await getUrl(cli, config.port);
   config.detailedLogs = cli.detailedLogs;
   config.live = cli.live;
   config.logs = cli.logs;