Skip to content

Commit 6b5bcf4

Browse files
authored
feat(create-twilio-function): add runtime-handler to js projects (#321)
Seems that adding the runtime handler in create-twilio-function only previously applied to TypeScript projects. This adds it into JavaScript projects too.
1 parent 7f9205e commit 6b5bcf4

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

packages/create-twilio-function/src/create-twilio-function/create-files.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,12 @@ const typescriptDeps = {
2727
'@twilio-labs/serverless-runtime-types': versions.serverlessRuntimeTypes,
2828
...javaScriptDeps,
2929
};
30-
const javaScriptDevDeps = { 'twilio-run': versions.twilioRun };
31-
const typescriptDevDeps = {
30+
const javaScriptDevDeps = {
3231
'@twilio/runtime-handler': versions.twilioRuntimeHandler,
3332
'twilio-run': versions.twilioRun,
33+
};
34+
const typescriptDevDeps = {
35+
...javaScriptDevDeps,
3436
typescript: versions.typescript,
3537
copyfiles: versions.copyfiles,
3638
};

packages/create-twilio-function/tests/create-files.test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,9 @@ describe('create-files', () => {
7979
expect(packageJSON.devDependencies['twilio-run']).toEqual(
8080
versions.twilioRun
8181
);
82+
expect(packageJSON.devDependencies['@twilio/runtime-handler']).toEqual(
83+
versions.twilioRuntimeHandler
84+
);
8285
expect(packageJSON.dependencies['twilio']).toEqual(versions.twilio);
8386
cleanUp();
8487
});
@@ -102,6 +105,9 @@ describe('create-files', () => {
102105
expect(packageJSON.devDependencies.typescript).toEqual(
103106
versions.typescript
104107
);
108+
expect(packageJSON.devDependencies['@twilio/runtime-handler']).toEqual(
109+
versions.twilioRuntimeHandler
110+
);
105111
expect(
106112
packageJSON.dependencies['@twilio-labs/serverless-runtime-types']
107113
).toEqual(versions.serverlessRuntimeTypes);

0 commit comments

Comments
 (0)