Skip to content

Commit ce571ae

Browse files
committed
Use buildifier_test instead of 'mode = diff'
``` DEBUG: /home/runner/.cache/bazel/_bazel_runner/2f1e0776f91a8e59682a44ab965a403c/external/com_github_bazelbuild_buildtools/buildifier/internal/factory.bzl:17:10: DEPRECATION NOTICE: value 'diff' for attribute 'mode' will be removed in the future. Migrate '@//:buildifier-diff' to buildifier_test. DEBUG: /home/runner/.cache/bazel/_bazel_runner/2f1e0776f91a8e59682a44ab965a403c/external/com_github_bazelbuild_buildtools/buildifier/internal/factory.bzl:28:10: DEPRECATION NOTICE: attribute 'diff_command' will be removed in the future. Migrate '@//:buildifier-diff' to buildifier_test. ```
1 parent e218e6e commit ce571ae

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/workflow.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
- name: Test for buildifier suggestions
7575
uses: tweag/run-nix-shell@v0
7676
with:
77-
run: bazel run //:buildifier-diff
77+
run: bazel test //:buildifier-test
7878

7979
all_ci_tests:
8080
runs-on: ubuntu-latest

BUILD.bazel

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
load("@com_github_bazelbuild_buildtools//buildifier:def.bzl", "buildifier")
1+
load("@com_github_bazelbuild_buildtools//buildifier:def.bzl", "buildifier", "buildifier_test")
22

33
exports_files(["defs.bzl"])
44

5-
buildifier(
6-
name = "buildifier-diff",
5+
buildifier_test(
6+
name = "buildifier-test",
77
buildifier = "@buildifier//:buildifier",
88
diff_command = "diff -u",
9-
mode = "diff",
9+
no_sandbox = True,
10+
workspace = ":WORKSPACE",
1011
)
1112

1213
buildifier(

0 commit comments

Comments
 (0)