Skip to content

Commit 4afc93f

Browse files
KanjiMonstersmb49
authored andcommitted
net: dsa: b53: fix learning on VLAN unaware bridges
BugLink: https://bugs.launchpad.net/bugs/2115252 [ Upstream commit 9f34ad8 ] When VLAN filtering is off, we configure the switch to forward, but not learn on VLAN table misses. This effectively disables learning while not filtering. Fix this by switching to forward and learn. Setting the learning disable register will still control whether learning actually happens. Fixes: dad8d7c ("net: dsa: b53: Properly account for VLAN filtering") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20250429201710.330937-11-jonas.gorski@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
1 parent 361fac0 commit 4afc93f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ static void b53_enable_vlan(struct b53_device *dev, int port, bool enable,
383383
vc4 |= VC4_ING_VID_VIO_DROP << VC4_ING_VID_CHECK_S;
384384
vc5 |= VC5_DROP_VTABLE_MISS;
385385
} else {
386-
vc4 |= VC4_ING_VID_VIO_FWD << VC4_ING_VID_CHECK_S;
386+
vc4 |= VC4_NO_ING_VID_CHK << VC4_ING_VID_CHECK_S;
387387
vc5 &= ~VC5_DROP_VTABLE_MISS;
388388
}
389389

0 commit comments

Comments
 (0)