fix override storage driver for json schemas

due to heavy reliance on `classmethod`, adding the ability to swap out
the storage driver arbitrarily withouth using a clobber-able class
attribute leads to peppering the storage_driver argument in all the
class method calls. ugly but right now, looks like the shortest path

Author: tutankalex

nbs/00_core.ipynb

@@ -1,7 +1,6 @@
 {
  "cells": [
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -255,8 +254,8 @@
     "        '''\n",
     "        self.storage_driver = storage_driver or self.__class__.DEFAULT_STORAGE_DRIVER\n",
     "        if isinstance(json_schema, (str, dict)):\n",
-    "            self._json_schema = self.__class__.load_json(json_schema)\n",
-    "        elif (default_schema := self.__class__.get_default_json_schema()):\n",
+    "            self._json_schema = self.__class__.load_json(json_schema, storage_driver=self.storage_driver)\n",
+    "        elif (default_schema := self.__class__.get_default_json_schema(storage_driver=self.storage_driver)):\n",
     "            self._json_schema = default_schema\n",
     "        else:\n",
     "            raise Exception('did not receive or find a JSON schema')\n",
@@ -286,7 +285,8 @@
     "        with storage_driver.open(dotenv_path) as ifile:\n",
     "            config = dotenv.dotenv_values(stream=ifile)\n",
     "        return cls.load_validated_config(\n",
-    "            json_schema or cls.get_default_json_schema(), config)"
+    "            json_schema or cls.get_default_json_schema(storage_driver=storage_driver),\n",
+    "            config, storage_driver=storage_driver)"
    ]
   },
   {
@@ -507,9 +507,7 @@
    "outputs": [],
    "source": [
     "#| hide\n",
-    "# FIXME this test clobbers the environment\n",
-    "# FIXME this is a code smell on the class design\n",
-    "# here we're testing the ability to override the storage driver (memoryfs here)\n",
+    "# test ability to override the storage driver (memoryfs here)\n",
     "\n",
     "from fs.memoryfs import MemoryFS\n",
     "memfs = MemoryFS()\n",
@@ -519,8 +517,7 @@
     "    ofile.write(json.dumps(example_properties_schema))\n",
     "    os.environ['CONFIG_VALIDATOR_JSON_SCHEMA'] = ofile.name\n",
     "\n",
-    "ConfigValidator.DEFAULT_STORAGE_DRIVER = memfs\n",
-    "validator = ConfigValidator()\n",
+    "validator = ConfigValidator(storage_driver=memfs)\n",
     "validated_config = validator.load_config({\n",
     "    'string_value_with_enum': 'these',\n",
     "    'MY_INTEGER_VALUE': '-85',\n",
@@ -532,9 +529,18 @@
     "    'MY_INTEGER_VALUE': -85,\n",
     "    'A_NUMERIC_VALUE': 12300.0,\n",
     "    '_____A_STRING_VALUE____with_default__': 'underscores_and spaces',\n",
-    "})\n",
-    "\n",
+    "})"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "#| hide\n",
     "# test loading dotenv from an arbitrary file\n",
+    "\n",
     "memfs.makedirs('special-bespoke-location', recreate=True)\n",
     "with memfs.open('special-bespoke-location/my-own.env', 'w') as ofile:\n",
     "    ofile.write('\\n'.join([\n",
@@ -543,12 +549,42 @@
     "        'A_NUMERIC_VALUE=1167.89',\n",
     "    ]))\n",
     "\n",
-    "validated_dotenv = validator.load_dotenv(dotenv_path='special-bespoke-location/my-own.env')\n",
+    "validated_dotenv = validator.load_dotenv(\n",
+    "    dotenv_path='special-bespoke-location/my-own.env',\n",
+    "    storage_driver=memfs,\n",
+    ")\n",
+    "\n",
     "test_eq(validated_dotenv, {\n",
     "    'string_value_with_enum': 'only',\n",
     "    'MY_INTEGER_VALUE': 9989998,\n",
     "    'A_NUMERIC_VALUE': 1167.89,\n",
     "    '_____A_STRING_VALUE____with_default__': 'underscores_and spaces',\n",
+    "})"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "#| hide\n",
+    "# test using custom json schema\n",
+    "\n",
+    "with memfs.open('foo.schema.json', 'w') as ofile:\n",
+    "    ofile.write(json.dumps({\n",
+    "        'type': 'object',\n",
+    "        'properties': {\n",
+    "            'A_NUMERIC_VALUE': { 'type': 'number' },\n",
+    "        }\n",
+    "    }))\n",
+    "validated_dotenv = ConfigValidator.load_dotenv(\n",
+    "    json_schema='foo.schema.json',\n",
+    "    dotenv_path='special-bespoke-location/my-own.env',\n",
+    "    storage_driver=memfs,\n",
+    ")\n",
+    "test_eq(validated_dotenv, {\n",
+    "    'A_NUMERIC_VALUE': 1167.89,\n",
     "})\n",
     "\n",
     "test_fail(validator.load_dotenv, kwargs={'dotenv_path': 'non-existent-location-own.env'})"

schematized_config/__init__.py

@@ -1 +1 @@
-__version__ = "0.0.3"
+__version__ = "0.0.4"

schematized_config/core.py

@@ -131,8 +131,8 @@ def __init__(self, json_schema: Union[str, dict]=None, storage_driver: FS=None):
         '''
         self.storage_driver = storage_driver or self.__class__.DEFAULT_STORAGE_DRIVER
         if isinstance(json_schema, (str, dict)):
-            self._json_schema = self.__class__.load_json(json_schema)
-        elif (default_schema := self.__class__.get_default_json_schema()):
+            self._json_schema = self.__class__.load_json(json_schema, storage_driver=self.storage_driver)
+        elif (default_schema := self.__class__.get_default_json_schema(storage_driver=self.storage_driver)):
             self._json_schema = default_schema
         else:
             raise Exception('did not receive or find a JSON schema')
@@ -162,4 +162,5 @@ def load_dotenv(cls, json_schema: Union[str, dict]=None, dotenv_path: str=None,
         with storage_driver.open(dotenv_path) as ifile:
             config = dotenv.dotenv_values(stream=ifile)
         return cls.load_validated_config(
-            json_schema or cls.get_default_json_schema(), config)
+            json_schema or cls.get_default_json_schema(storage_driver=storage_driver),
+            config, storage_driver=storage_driver)

settings.ini

@@ -1,7 +1,7 @@
 [DEFAULT]
 repo = python-schematized-config
 lib_name = python-schematized-config
-version = 0.0.3
+version = 0.0.4
 min_python = 3.7
 license = apache2
 black_formatting = False