fixup! Add value-based stall detection to catch stuck progress

Author: m7kvqbe1

lib/StallDetector.ts

@@ -1,24 +1,17 @@
 import { log } from './logger.js'
 import type { StallDetectionOptions } from './options.js'
-import type { HttpStack } from './options.js'
 
 export class StallDetector {
   private options: StallDetectionOptions
-  private httpStack: HttpStack
   private onStallDetected: (reason: string) => void
 
   private intervalId: ReturnType<typeof setInterval> | null = null
   private lastProgressTime = 0
   private lastProgressValue = 0
   private isActive = false
 
-  constructor(
-    options: StallDetectionOptions,
-    httpStack: HttpStack,
-    onStallDetected: (reason: string) => void,
-  ) {
+  constructor(options: StallDetectionOptions, onStallDetected: (reason: string) => void) {
     this.options = options
-    this.httpStack = httpStack
     this.onStallDetected = onStallDetected
   }
 

lib/upload.ts

@@ -850,17 +850,13 @@ export class BaseUpload {
     if (this.options.stallDetection?.enabled) {
       // Only enable stall detection if the HTTP stack supports progress events
       if (this.options.httpStack.supportsProgressEvents()) {
-        stallDetector = new StallDetector(
-          this.options.stallDetection,
-          this.options.httpStack,
-          (reason: string) => {
-            // Handle stall by aborting the current request and triggering retry
-            if (this._req) {
-              this._req.abort()
-            }
-            this._retryOrEmitError(new Error(`Upload stalled: ${reason}`))
-          },
-        )
+        stallDetector = new StallDetector(this.options.stallDetection, (reason: string) => {
+          // Handle stall by aborting the current request and triggering retry
+          if (this._req) {
+            this._req.abort()
+          }
+          this._retryOrEmitError(new Error(`Upload stalled: ${reason}`))
+        })
         // Don't start yet - will be started after onBeforeRequest
       } else {
         log(