fixup! Add stall detection to recover from frozen uploads

Author: m7kvqbe1

test/spec/test-stall-detection.js

@@ -328,5 +328,85 @@ describe('tus-stall-detection', () => {
       // Stall detection should not have triggered during the onBeforeRequest delay
       expect(options.onError.calls.count()).toBe(0)
     })
+
+    it('should detect stalls when progress events stop mid-upload', async () => {
+      const testStack = new TestHttpStack()
+      const file = getBlob('hello world'.repeat(100)) // Larger file for multiple progress events
+
+      let progressCallCount = 0
+      let progressHandler = null
+
+      // Override createRequest to capture and control progress events
+      const originalCreateRequest = testStack.createRequest.bind(testStack)
+      testStack.createRequest = function(method, url) {
+        const req = originalCreateRequest(method, url)
+
+        if (method === 'PATCH') {
+          const originalSetProgressHandler = req.setProgressHandler.bind(req)
+          req.setProgressHandler = function(handler) {
+            progressHandler = handler
+            originalSetProgressHandler(handler)
+          }
+
+          // Override send to simulate progress events that stop
+          const originalSend = req.send.bind(req)
+          req.send = async function(body) {
+            const result = originalSend(body)
+
+            // Simulate some progress events then stop
+            if (progressHandler && body) {
+              const totalSize = await getBodySize(body)
+              // Send progress events for first 30% of upload
+              for (let i = 0; i <= 3; i++) {
+                progressCallCount++
+                progressHandler(Math.floor(totalSize * 0.1 * i))
+                await new Promise(resolve => setTimeout(resolve, 50))
+              }
+              // Then stop sending progress events to simulate a stall
+            }
+
+            return result
+          }
+        }
+
+        return req
+      }
+
+      const options = {
+        httpStack: testStack,
+        endpoint: 'https://tus.io/uploads',
+        stallDetection: {
+          enabled: true,
+          checkInterval: 100,
+          stallTimeout: 200,
+        },
+        retryDelays: null, // No retries to get immediate error
+        onError: waitableFunction('onError'),
+        onProgress: waitableFunction('onProgress'),
+      }
+
+      const upload = new Upload(file, options)
+      upload.start()
+
+      // Handle the POST request
+      const req = await testStack.nextRequest()
+      expect(req.method).toBe('POST')
+      req.respondWith({
+        status: 201,
+        responseHeaders: {
+          Location: '/uploads/12345',
+        },
+      })
+
+      // The PATCH request will start sending progress events then stall
+
+      // Wait for stall detection to trigger
+      const error = await options.onError.toBeCalled()
+      expect(error.message).toContain('Upload stalled')
+
+      // Verify that we received some progress events before the stall
+      expect(progressCallCount).toBeGreaterThan(0)
+      expect(options.onProgress.calls.count()).toBeGreaterThan(0)
+    })
   })
 })