Fix caching in standalone FDW extension. Closes #480

Author: pskrbasu

fdw.go

@@ -133,20 +133,9 @@ func goFdwGetRelSize(state *C.FdwPlanState, root *C.PlannerInfo, rows *C.double,
 
 	pluginHub := hub.GetHub()
 
-	// get connection name
-	connName := GetSchemaNameFromForeignTableId(types.Oid(state.foreigntableid))
-
-	log.Println("[TRACE] connection name:", connName)
-
-	serverOpts := GetForeignServerOptionsFromFTableId(types.Oid(state.foreigntableid))
-	err := pluginHub.ProcessImportForeignSchemaOptions(serverOpts, connName)
-	if err != nil {
-		FdwError(sperr.WrapWithMessage(err, "failed to process options"))
-	}
-
 	// reload connection config
 	// TODO remove need for fdw to load connection config
-	_, err = pluginHub.LoadConnectionConfig()
+	_, err := pluginHub.LoadConnectionConfig()
 	if err != nil {
 		log.Printf("[ERROR] LoadConnectionConfig failed %v ", err)
 		FdwError(err)

hub/hub_local.go

@@ -155,6 +155,7 @@ func (l *HubLocal) ProcessImportForeignSchemaOptions(opts types.Options, connect
 	// do we already have this connection
 	connectionConfig, ok := l.connections[connection]
 	if ok {
+		log.Println("[INFO] connection already exists, updating ")
 		// we have already set the config - update it
 		connectionConfig.Config = config
 		return l.UpdateConnectionConfig(connection, config)