Skip to content

Load additional_env_vars last for ECS #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Load additional_env_vars last for ECS #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eef52b
Add `additional_env_vars` to end of env vars list so they can overrid…
jonthemiller Sep 15, 2025
224773d
cleanup autoformat on save
jonthemiller Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/aws_ecs/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ locals {
ecs_telemetry_fluentbit_image = var.ecs_telemetry_fluentbit_image != "" ? var.ecs_telemetry_fluentbit_image : format("%s:%s", "tryretool/retool-aws-for-fluent-bit", split(":", var.ecs_retool_image)[1])

environment_variables = concat(
var.additional_env_vars, # add additional environment variables
local.base_environment_variables,
local.temporal_mtls_config,
var.code_executor_enabled ? [
Expand Down Expand Up @@ -109,7 +108,8 @@ locals {
"name" : "WORKFLOW_TEMPORAL_TLS_ENABLED",
"value" : tostring(var.temporal_cluster_config.tls_enabled)
}
]
],
var.additional_env_vars, # add additional environment variables after defaults so they can override when necessary
)

task_log_configuration = (
Expand Down
4 changes: 2 additions & 2 deletions modules/aws_ecs_ec2/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
locals {
environment_variables = concat(
var.additional_env_vars, # add additional environment variables
[
{
name = "NODE_ENV"
Expand Down Expand Up @@ -50,6 +49,7 @@ locals {
"name": "DEPLOYMENT_TEMPLATE_TYPE"
"value": "aws-ecs-ec2-terraform-deprecated"
}
]
],
var.additional_env_vars, # add additional environment variables if provided so they can override defaults
)
}