add BigInt::from_i128, and add skeleton methods for Seb

Author: lockels

nova_vm/src/builtin_strings

@@ -28,7 +28,7 @@ __proto__
 #[cfg(feature = "math")]abs
 #[cfg(feature = "math")]acos
 #[cfg(feature = "math")]acosh
-#[cfg(any(feature = "atomics", feature = "set", feature = "weak-refs"))]add
+#[cfg(any(feature = "atomics", feature = "set", feature = "weak-refs", feature = "temporal"))]add
 AggregateError
 all
 allSettled
@@ -389,6 +389,7 @@ setPrototypeOf
 shift
 #[cfg(feature = "math")]sign
 #[cfg(feature = "math")]sin
+#[cfg(feature = "temporal")]since
 #[cfg(feature = "math")]sinh
 size
 slice
@@ -414,6 +415,7 @@ String Iterator
 #[cfg(feature = "array-buffer")]subarray
 #[cfg(feature = "annex-b-string")]substr
 substring
+#[cfg(feature = "temporal")]subtract
 #[cfg(feature = "proposal-math-sum")]sumPrecise
 #[cfg(feature = "annex-b-string")]sup
 symbol
@@ -485,6 +487,7 @@ undefined
 unregister
 unscopables
 unshift
+#[cfg(feature = "temporal")]until
 URIError
 #[cfg(feature = "date")]UTC
 value

nova_vm/src/ecmascript/builtins/temporal/instant.rs

@@ -361,6 +361,34 @@ impl Builtin for TemporalInstantPrototypeGetEpochNanoSeconds {
         Behaviour::Regular(TemporalInstantPrototype::get_epoch_nanoseconds);
 }
 
+struct TemporalInstantPrototypeAdd;
+impl Builtin for TemporalInstantPrototypeAdd {
+    const NAME: String<'static> = BUILTIN_STRING_MEMORY.add;
+    const LENGTH: u8 = 1;
+    const BEHAVIOUR: Behaviour = Behaviour::Regular(TemporalInstantPrototype::add);
+}
+
+struct TemporalInstantPrototypeSubtract;
+impl Builtin for TemporalInstantPrototypeSubtract {
+    const NAME: String<'static> = BUILTIN_STRING_MEMORY.subtract;
+    const LENGTH: u8 = 1;
+    const BEHAVIOUR: Behaviour = Behaviour::Regular(TemporalInstantPrototype::subtract);
+}
+
+struct TemporalInstantPrototypeUntil;
+impl Builtin for TemporalInstantPrototypeUntil {
+    const NAME: String<'static> = BUILTIN_STRING_MEMORY.until;
+    const LENGTH: u8 = 1;
+    const BEHAVIOUR: Behaviour = Behaviour::Regular(TemporalInstantPrototype::until);
+}
+
+struct TemporalInstantPrototypeSince;
+impl Builtin for TemporalInstantPrototypeSince {
+    const NAME: String<'static> = BUILTIN_STRING_MEMORY.since;
+    const LENGTH: u8 = 1;
+    const BEHAVIOUR: Behaviour = Behaviour::Regular(TemporalInstantPrototype::since);
+}
+
 impl TemporalInstantPrototype {
     pub fn create_intrinsic(agent: &mut Agent, realm: Realm<'static>, _: NoGcScope) {
         let intrinsics = agent.get_realm_record_by_id(realm).intrinsics();
@@ -369,11 +397,15 @@ impl TemporalInstantPrototype {
         let instant_constructor = intrinsics.temporal_instant();
 
         OrdinaryObjectBuilder::new_intrinsic_object(agent, realm, this)
-            .with_property_capacity(3)
+            .with_property_capacity(7)
             .with_prototype(object_prototype)
             .with_constructor_property(instant_constructor)
             .with_builtin_function_property::<TemporalInstantPrototypeGetEpochMilliseconds>()
             .with_builtin_function_property::<TemporalInstantPrototypeGetEpochNanoSeconds>()
+            .with_builtin_function_property::<TemporalInstantPrototypeAdd>()
+            .with_builtin_function_property::<TemporalInstantPrototypeSubtract>()
+            .with_builtin_function_property::<TemporalInstantPrototypeUntil>()
+            .with_builtin_function_property::<TemporalInstantPrototypeSince>()
             .build();
     }
 
@@ -410,7 +442,43 @@ impl TemporalInstantPrototype {
             .bind(gc.nogc());
         // 3. Return instant.[[EpochNanoseconds]].
         let value = instant.inner_instant(agent).epoch_nanoseconds().as_i128();
-        todo!()
+        Ok(BigInt::from_i128(agent, value).into())
+    }
+
+    fn add<'gc>(
+        _agent: &mut Agent,
+        _this_value: Value,
+        _args: ArgumentsList,
+        mut _gc: GcScope<'gc, '_>,
+    ) -> JsResult<'gc, Value<'gc>> {
+        unimplemented!()
+    }
+
+    fn subtract<'gc>(
+        _agent: &mut Agent,
+        _this_value: Value,
+        _args: ArgumentsList,
+        mut _gc: GcScope<'gc, '_>,
+    ) -> JsResult<'gc, Value<'gc>> {
+        unimplemented!()
+    }
+
+    fn until<'gc>(
+        _agent: &mut Agent,
+        _this_value: Value,
+        _args: ArgumentsList,
+        mut _gc: GcScope<'gc, '_>,
+    ) -> JsResult<'gc, Value<'gc>> {
+        unimplemented!()
+    }
+
+    fn since<'gc>(
+        _agent: &mut Agent,
+        _this_value: Value,
+        _args: ArgumentsList,
+        mut _gc: GcScope<'gc, '_>,
+    ) -> JsResult<'gc, Value<'gc>> {
+        unimplemented!()
     }
 }
 

nova_vm/src/ecmascript/types/language/bigint.rs

@@ -207,6 +207,15 @@ impl<'a> BigInt<'a> {
         }
     }
 
+    #[inline]
+    pub fn from_i128(agent: &mut Agent, value: i128) -> Self {
+        if let Ok(result) = SmallBigInt::try_from(value) {
+            Self::SmallBigInt(result)
+        } else {
+            agent.heap.create(BigIntHeapData { data: value.into() })
+        }
+    }
+
     #[inline]
     pub(crate) fn from_num_bigint(agent: &mut Agent, value: num_bigint::BigInt) -> Self {
         if let Ok(result) = SmallBigInt::try_from(&value) {