Skip to content

Conversation

@Flgado
Copy link
Member

@Flgado Flgado commented Dec 1, 2025

Run end-to-end tests against two Grafana versions in CI and ensure Grafana is fully ready before testing

Supersedes #321 and #303

@cla-bot cla-bot bot added the cla-signed label Dec 1, 2025
@Flgado Flgado changed the base branch from test-old-grafana to main December 1, 2025 12:42
@cla-bot
Copy link

cla-bot bot commented Dec 1, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Dec 1, 2025
@Flgado Flgado force-pushed the test-old-grafana-wip branch from df26d7b to 657fdde Compare December 1, 2025 14:40
@cla-bot
Copy link

cla-bot bot commented Dec 1, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

3 similar comments
@cla-bot
Copy link

cla-bot bot commented Dec 1, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Dec 1, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Dec 1, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Flgado
Copy link
Member Author

Flgado commented Dec 1, 2025

@nineinchnick I think we may have a problem in the plugin. If you create a datasource A with token B, and then create another datasource but use token X, it will actually use token B, because we’re storing the token in a global variable. That happens on the e2e

@Flgado Flgado force-pushed the test-old-grafana-wip branch from 8520bcb to f853570 Compare December 1, 2025 21:15
@cla-bot cla-bot bot added the cla-signed label Dec 1, 2025
@Flgado Flgado changed the title Make test generic to work on old and new grafana version Make e2e generic to work on old and new grafana version Dec 1, 2025
@Flgado Flgado marked this pull request as ready for review December 1, 2025 21:15
@nineinchnick
Copy link
Member

Yup, seems the issue is at

Looks like it's enough to move it into the client struct.

@Flgado
Copy link
Member Author

Flgado commented Dec 2, 2025

yes @nineinchnick that should be enough. Will create a issue for that wdyt ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants