-
Notifications
You must be signed in to change notification settings - Fork 27
Make e2e generic to work on old and new grafana version #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
|
df26d7b to
657fdde
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
|
3 similar comments
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
|
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
|
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jan Waś.
|
|
@nineinchnick I think we may have a problem in the plugin. If you create a datasource A with token B, and then create another datasource but use token X, it will actually use token B, because we’re storing the token in a global variable. That happens on the e2e |
8520bcb to
f853570
Compare
|
Yup, seems the issue is at grafana-trino/pkg/trino/client/client.go Line 17 in 7b190bc
Looks like it's enough to move it into the client struct. |
|
yes @nineinchnick that should be enough. Will create a issue for that wdyt ? |
Run end-to-end tests against two Grafana versions in CI and ensure Grafana is fully ready before testing
Supersedes #321 and #303